Incorporate New Optimizely endpoint in event dispatcher and bump version #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
jordangarcia
pushed a commit
that referenced
this pull request
Jan 25, 2019
) - ChangeFetchUrlDatafileLoader class implementation to use XMLHttpRequest instead of fetch - Use karma to run tests - Built using karma-webpack. TS compiled via ts-loader - Use karma-chrome-launcher and puppeteer to run in headless Chrome - Remove old dependencies that are no longer used - Update tests to not spam log messages or send real events to logx
mjc1283
added a commit
that referenced
this pull request
Apr 22, 2019
Summary: Add `BrowserDatafileManager`, similar to `NodeDatafileManager`: a subclass of `HttpPollingDatafileManager` implementing `makeGetRequest` using `XMLHttpRequest`. The caching described in the design is not yet implemented. Test plan: Unit tests Issues: https://optimizely.atlassian.net/browse/OASIS-4310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mikeng13 @aliabbasrizvi @delikat @vraja2