Skip to content

Converting util/fns from CJS to ES module #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
var conditionTreeEvaluator = require('../condition_tree_evaluator');
var customAttributeConditionEvaluator = require('../custom_attribute_condition_evaluator');
var enums = require('../../utils/enums');
var fns = require('../../utils/fns');
var fns = require('../../utils/fns').default;
var sprintf = require('@optimizely/js-sdk-utils').sprintf;
var logging = require('@optimizely/js-sdk-logging');
var logger = logging.getLogger();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License. *
***************************************************************************/

var fns = require('../../utils/fns');
var fns = require('../../utils/fns').default;
var enums = require('../../utils/enums');
var sprintf = require('@optimizely/js-sdk-utils').sprintf;

Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/core/decision_service/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
var AudienceEvaluator = require('../audience_evaluator');
var bucketer = require('../bucketer');
var enums = require('../../utils/enums');
var fns = require('../../utils/fns');
var fns = require('../../utils/fns').default;
var projectConfig = require('../project_config');
var stringValidator = require('../../utils/string_value_validator');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
var logging = require('@optimizely/js-sdk-logging');

var attributesValidator = require('../../utils/attributes_validator');
var fns = require('../../utils/fns');
var fns = require('../../utils/fns').default;
var eventTagUtils = require('../../utils/event_tag_utils');
var projectConfig = require('../project_config');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/
var projectConfig = require('../project_config');
var eventHelpers = require('./event_helpers');
var fns = require('../../utils/fns');
var fns = require('../../utils/fns').default;

var chai = require('chai');
var assert = chai.assert;
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/core/event_builder/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/
var enums = require('../../utils/enums');
var fns = require('../../utils/fns');
var fns = require('../../utils/fns').default;
var eventTagUtils = require('../../utils/event_tag_utils');
var projectConfig = require('../project_config');
var attributeValidator = require('../../utils/attributes_validator');
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/core/project_config/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
var fns = require('../../utils/fns');
var fns = require('../../utils/fns').default;
var enums = require('../../utils/enums');
var jsSdkUtils = require('@optimizely/js-sdk-utils');
var configValidator = require('../../utils/config_validator');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ var logger = logging.getLogger();

var forEach = require('lodash/forEach');
var cloneDeep = require('lodash/cloneDeep');
var fns = require('../../utils/fns');
var fns = require('../../utils/fns').default;
var chai = require('chai');
var assert = chai.assert;
var loggerPlugin = require('../../plugins/logger');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

var fns = require('../../utils/fns');
var fns = require('../../utils/fns').default;
var sprintf = require('@optimizely/js-sdk-utils').sprintf;
var logging = require('@optimizely/js-sdk-logging');
var configValidator = require('../../utils/config_validator');
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/index.browser.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/
var logging = require('@optimizely/js-sdk-logging');
var fns = require('./utils/fns');
var fns = require('./utils/fns').default;
var configValidator = require('./utils/config_validator');
var defaultErrorHandler = require('./plugins/error_handler');
var defaultEventDispatcher = require('./plugins/event_dispatcher/index.browser');
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/index.node.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ var configValidator = require('./utils/config_validator');
var defaultErrorHandler = require('./plugins/error_handler');
var defaultEventDispatcher = require('./plugins/event_dispatcher/index.node');
var enums = require('./utils/enums');
var fns = require('./utils/fns');
var fns = require('./utils/fns').default;
var jsonSchemaValidator = require('./utils/json_schema_validator');
var loggerPlugin = require('./plugins/logger');
var Optimizely = require('./optimizely');
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/index.react_native.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/
var logging = require('@optimizely/js-sdk-logging');
var fns = require('./utils/fns');
var fns = require('./utils/fns').default;
var configValidator = require('./utils/config_validator');
var defaultErrorHandler = require('./plugins/error_handler');
var defaultEventDispatcher = require('./plugins/event_dispatcher/index.browser');
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/optimizely/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License. *
***************************************************************************/

var fns = require('../utils/fns');
var fns = require('../utils/fns').default;
var attributesValidator = require('../utils/attributes_validator');
var decisionService = require('../core/decision_service');
var enums = require('../utils/enums');
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/optimizely/index.tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ var eventBuilder = require('../core/event_builder/index.js');
var eventDispatcher = require('../plugins/event_dispatcher/index.node');
var eventProcessor = require('@optimizely/js-sdk-event-processor');
var errorHandler = require('../plugins/error_handler');
var fns = require('../utils/fns');
var fns = require('../utils/fns').default;
var jsonSchemaValidator = require('../utils/json_schema_validator');
var logger = require('../plugins/logger');
var decisionService = require('../core/decision_service');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
*/

var sprintf = require('@optimizely/js-sdk-utils').sprintf;
var fns = require('../../utils/fns');
var fns = require('../../utils/fns').default;

var ERROR_MESSAGES = require('../enums').ERROR_MESSAGES;
var MODULE_NAME = 'ATTRIBUTES_VALIDATOR';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

var fns = require('../fns');
var fns = require('../fns').default;

/**
* Return true if the argument is a valid event batch size, false otherwise
Expand Down
Loading