Converting util/fns from CJS to ES module #424
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjc1283
suggested changes
Mar 23, 2020
| @@ -7,15 +7,16 @@ | |||
| "react-native": "lib/index.react_native.js", | |||
| "typings": "lib/index.d.ts", | |||
| "scripts": { | |||
| "test": "mocha ./lib/*.tests.js ./lib/**/*.tests.js ./lib/**/**/*tests.js --recursive --exit --require lib/tests/exit_on_unhandled_rejection.js", | |||
| "build": "./node_modules/.bin/babel src --out-dir lib --presets=@babel/env", | |||
There was a problem hiding this comment.
Why do we need babel? I think we only need a bundler. We can use Rollup, like we do in React SDK.
fayyazarshad
force-pushed
the
fayyaz/convert-to-es6-fns
branch
from
85c8a7d to
b9d5122
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This activity is part of reducing bundle size, 5to6codemod is used for the automatic transformation but the conversion only include import/export transforms.
Test plan
All unit test and FSC are getting passed