feat(decision-listener): Incorporated new decision notification listener changes. #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| FEATURE: 'feature', | ||
| FEATURE_TEST: 'feature-test', | ||
| FEATURE_VARIABLE: 'feature_variable', |
There was a problem hiding this comment.
Missed it earlier. This needs to be feature-variable
| @@ -89,10 +89,16 @@ module.exports = { | |||
|
|
|||
| projectConfig.forcedVariationMap = {}; | |||
|
|
|||
| // Object containing experiment Ids that exist in any feature | |||
| // for checking that experiment is a feature experiment or not. | |||
| projectConfig.featureExperimentsMap = {}; | |||
There was a problem hiding this comment.
More meaningful is experimentFeatureMap.
| projectConfig.featureKeyMap = fns.keyBy(projectConfig.featureFlags || [], 'key'); | ||
| fns.forOwn(projectConfig.featureKeyMap, function(feature) { | ||
| feature.variableKeyMap = fns.keyBy(feature.variables, 'key'); | ||
| fns.forEach(feature.experimentIds || [], function(experimentId) { | ||
| // Add this experiment in feature experiment map. | ||
| projectConfig.featureExperimentsMap[experimentId] = true; |
There was a problem hiding this comment.
Instead of true, if we can assign featureId would be more meaning. @aliabbasrizvi What do you suggest?
There was a problem hiding this comment.
Agreed. It would be much better if we add featureId on experiment and use that.
| * any feature, false otherwise. | ||
| */ | ||
| isFeatureExperiment: function(projectConfig, experimentId) { | ||
| return projectConfig.featureExperimentsMap[experimentId]; |
There was a problem hiding this comment.
This condition after making suggested changes, should be like
projectConfig.featureExperimentsMap[experimentId] != undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan