Added unit tests.

Author: mfahadahmed

packages/optimizely-sdk/lib/core/project_config/index.js

@@ -89,10 +89,16 @@ module.exports = {
 
     projectConfig.forcedVariationMap = {};
 
+    // Object containing experiment Ids that exist in any feature
+    // for checking that experiment is a feature experiment or not.
+    projectConfig.featureExperimentsMap = {};
+
     projectConfig.featureKeyMap = fns.keyBy(projectConfig.featureFlags || [], 'key');
     fns.forOwn(projectConfig.featureKeyMap, function(feature) {
       feature.variableKeyMap = fns.keyBy(feature.variables, 'key');
       fns.forEach(feature.experimentIds || [], function(experimentId) {
+        // Add this experiment in feature experiment map.
+        projectConfig.featureExperimentsMap[experimentId] = true;
         var experimentInFeature = projectConfig.experimentIdMap[experimentId];
         if (experimentInFeature.groupId) {
           feature.groupId = experimentInFeature.groupId;
@@ -598,17 +604,11 @@ module.exports = {
   /**
    * 
    * @param {Object} projectConfig
-   * @param {string} experimentKey
+   * @param {string} experimentId
    * @returns {boolean} Returns true if experiment belongs to
    * any feature, false otherwise.
    */
-  isFeatureExperiment: function(projectConfig, experimentKey) {
-    fns.forOwn(projectConfig.featureKeyMap, function(feature) {
-      if (feature.experimentIds && feature.experimentIds.indexOf(experimentKey)) {
-        return true;
-      }
-    });
-
-    return false;
+  isFeatureExperiment: function(projectConfig, experimentId) {
+    return projectConfig.featureExperimentsMap[experimentId];
   }
 };

packages/optimizely-sdk/lib/optimizely/index.js

@@ -343,7 +343,7 @@ Optimizely.prototype.getVariation = function(experimentKey, userId, attributes)
       }
 
       var variationKey = this.decisionService.getVariation(this.configObj, experimentKey, userId, attributes);
-      var decisionInfoType = projectConfig.isFeatureExperiment(this.configObj, experimentKey) ? DECISION_INFO_TYPES.FEATURE :
+      var decisionInfoType = projectConfig.isFeatureExperiment(this.configObj, experiment.id) ? DECISION_INFO_TYPES.FEATURE_TEST :
         DECISION_INFO_TYPES.AB_TEST;
 
       this.notificationCenter.sendNotifications(

packages/optimizely-sdk/lib/optimizely/index.tests.js

@@ -2438,6 +2438,37 @@ describe('lib/optimizely', function() {
               }
             });
           });
+
+          it('should send notification with variation key and type feature-test when getVariation returns feature experiment variation', function() {
+            var optly = new Optimizely({
+              clientEngine: 'node-sdk',
+              datafile: testData.getTestProjectConfigWithFeatures(),
+              eventBuilder: eventBuilder,
+              errorHandler: errorHandler,
+              eventDispatcher: eventDispatcher,
+              jsonSchemaValidator: jsonSchemaValidator,
+              logger: createdLogger,
+              isValidInstance: true,
+            });
+
+            optly.notificationCenter.addNotificationListener(
+              enums.NOTIFICATION_TYPES.DECISION,
+              decisionListener
+            );
+
+            bucketStub.returns('594099');
+            var variation = optly.getVariation('testing_my_feature', 'testUser');
+            assert.strictEqual(variation, 'variation2');
+            sinon.assert.calledWith(decisionListener, {
+              type: DECISION_INFO_TYPES.FEATURE_TEST,
+              userId: 'testUser',
+              attributes: {},
+              decisionInfo: {
+                experimentKey: 'testing_my_feature',
+                variationKey: variation
+              }
+            });
+          });
         });
 
         describe('feature management', function() {

packages/optimizely-sdk/lib/utils/enums/index.js

@@ -192,6 +192,7 @@ exports.NOTIFICATION_TYPES = {
 exports.DECISION_INFO_TYPES = {
   AB_TEST: 'ab-test',
   FEATURE: 'feature',
+  FEATURE_TEST: 'feature-test',
   FEATURE_VARIABLE: 'feature_variable',
 };