Skip to content

chore(deps): Upgrade to mocha@5 #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2018
Merged

Conversation

spencerwilson-optimizely
Copy link
Contributor

@spencerwilson-optimizely spencerwilson-optimizely commented Jul 3, 2018

Summary

  • Upgrade mocha 2.5.3 -> 5.2.0

Repro this branch with

npm install --save-dev mocha@latest

Among other things, this addresses the "critical" warning about growl visible both here in GitHub and in npm audit. The latter is notable because

npm audit automatically runs when you install a package with npm install

(source: npm audit Getting Started article)

For example, expand the npm install step of this PR's node 10 build: link.

Test plan

CI

@coveralls
Copy link

coveralls commented Jul 3, 2018

Coverage Status

Coverage remained the same at 97.11% when pulling c4fe79f on sw/upgrade-mocha into 49e1e08 on master.

@optimizely optimizely deleted a comment from coveralls Jul 3, 2018
@optimizely optimizely deleted a comment from coveralls Jul 3, 2018
@optimizely optimizely deleted a comment from coveralls Jul 3, 2018
@optimizely optimizely deleted a comment from coveralls Jul 3, 2018
@spencerwilson-optimizely spencerwilson-optimizely merged commit 4273292 into master Jul 3, 2018
@spencerwilson-optimizely spencerwilson-optimizely deleted the sw/upgrade-mocha branch July 3, 2018 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants