Skip to content

Commit 4273292

Browse files
chore(deps): Upgrade to mocha@5 (#141)
## Summary - Upgrade mocha 2.5.3 -> 5.2.0 Repro this branch with ```sh npm install --save-dev mocha@latest ``` Among other things, this addresses the "critical" warning about `growl` visible both here in GitHub and in `npm audit`. The latter is notable because > npm audit automatically runs when you install a package with npm install (source: [`npm audit` Getting Started article](https://docs.npmjs.com/getting-started/running-a-security-audit)) For example, expand the `npm install` step of this PR's node 10 build: [link](https://travis-ci.org/optimizely/javascript-sdk/jobs/399773189). ## Test plan CI
1 parent 49e1e08 commit 4273292

File tree

2 files changed

+47
-105
lines changed

2 files changed

+47
-105
lines changed

packages/optimizely-sdk/package-lock.json

Lines changed: 46 additions & 104 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/optimizely-sdk/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
"karma-sinon": "^1.0.5",
4747
"karma-webpack": "^2.0.3",
4848
"mathjs": "^3.3.0",
49-
"mocha": "^2.5.3",
49+
"mocha": "^5.2.0",
5050
"mocha-lcov-reporter": "^1.3.0",
5151
"nock": "^7.7.2",
5252
"sinon": "^2.3.1",

0 commit comments

Comments
 (0)