Skip to content

feat(ci): Only run test-xbrowser once #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 3, 2018
Merged

feat(ci): Only run test-xbrowser once #139

merged 7 commits into from
Jul 3, 2018

Conversation

spencerwilson-optimizely
Copy link
Contributor

@spencerwilson-optimizely spencerwilson-optimizely commented Jun 30, 2018 •
edited
Loading

Summary

  • Only run cross-browser tests once, rather than n times for each Node.js version in the Travis CI matrix

This should reduce contention in both Travis CI and BrowserStack.

Test plan

CI.

@spencerwilson-optimizely spencerwilson-optimizely changed the title feat(ci): Only run xbrowser-tests with the latest Node.js release feat(ci): Only run test-xbrowser once Jun 30, 2018
@coveralls
Copy link

coveralls commented Jun 30, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 97.11% when pulling 0df243f on sw/xbrowser-once into 0d314e7 on master.

mikeproeng37
mikeproeng37 approved these changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@spencerwilson-optimizely
Copy link
Contributor Author

Gotta try rewriting to use this

@spencerwilson-optimizely spencerwilson-optimizely merged commit 2faa9c4 into master Jul 3, 2018
@spencerwilson-optimizely spencerwilson-optimizely deleted the sw/xbrowser-once branch July 3, 2018 18:16
@spencerwilson-optimizely spencerwilson-optimizely mentioned this pull request Aug 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@tylerbrandt tylerbrandt Awaiting requested review from tylerbrandt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spencerwilson-optimizely @coveralls @mikeproeng37