Skip to content

Release 1.2.0 #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 22, 2017
Merged

Release 1.2.0 #98

merged 10 commits into from
Mar 22, 2017

Conversation

mikeproeng37
Copy link
Contributor

@optimizely/fullstack-devs

elliotykim and others added 10 commits February 14, 2017 15:10
The java core needs this class names to be intact to detect the right parser to use.  The Android SDK compiles gson so it should be available.  Ebay's proguard issue indicated that org.json.JSONObject was being used, however.  The reason gson is compiled is because Android's JSONObject and the JDKs are different and incompatible.  It's difficult to override Android's because it's part of the library.
@elliotykim elliotykim assigned elliotykim and unassigned elliotykim Mar 22, 2017
@elliotykim elliotykim self-requested a review March 22, 2017 15:52
Copy link
Contributor

@elliotykim elliotykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 0f998e1 into master Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants