Skip to content

Elliot/copyright 2 #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2017
Merged

Elliot/copyright 2 #84

merged 2 commits into from
Feb 14, 2017

Conversation

elliotykim
Copy link
Contributor

@optimizely/fullstack-devs

@vraja2 I found 4 files that were incorrectly added by the last copyright change commit:

  • test-app/src/main/java/com/optimizely/ab/android/test_app/MainActivity.java
  • test-app/src/main/java/com/optimizely/ab/android/test_app/SecondaryActivity.java
  • test-app/src/main/java/com/optimizely/ab/android/test_app/SecondaryFragment.java
  • test-app/src/main/res/layout/fragment_secondary.xml

This commit does not add them this time

@elliotykim elliotykim changed the base branch from master to devel January 23, 2017 16:05
Copy link
Contributor

@wangjoshuah wangjoshuah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to change these files if we haven't touched them?

@elliotykim
Copy link
Contributor Author

@wangjoshuah the date of the copyrights aren't changing, but rather updating the formatting (nice to have) and adding "and contributors" (necessary)

@elliotykim
Copy link
Contributor Author

@vraja2 review por favor

@vraja2
Copy link
Contributor

vraja2 commented Jan 26, 2017

@elliotykim should be 2016-2017, we can add a Gradle licensing plugin like we do in Java to do a verification check with a template, but for now just add it manually. @aliabbasrizvi

@elliotykim
Copy link
Contributor Author

@vraja2 updated the changed files with 2016-2017

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elliotykim elliotykim merged commit b0de25e into devel Feb 14, 2017
@elliotykim elliotykim deleted the elliot/copyright-2 branch February 14, 2017 11:20
elliotykim added a commit that referenced this pull request Feb 14, 2017
elliotykim added a commit that referenced this pull request Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants