Skip to content

ci(travis): include statik dependency #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 23, 2020
Merged

ci(travis): include statik dependency #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2343695
ci(travis): include statik dependency
juancarlostong Mar 23, 2020
1c37db3
ci(travis): add new stage to test building
juancarlostong Mar 23, 2020
4f69d63
ci(travis): add statik to alpine build too
juancarlostong Mar 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,16 @@ jobs:
script:
- pytest -vv -rA --diff-type=split tests/acceptance/test_acceptance/ --host http://localhost:8080

- stage: Build
- stage: Test Build using latest tag (no upload)
name: linux
os: linux
dist: xenial

script:
- export APP_VERSION=$(git describe --abbrev=0 --tags | tr -d '^v')
- $TRAVIS_BUILD_DIR/scripts/ci_create_packages.sh

- stage: Build and Upload
if: type = push AND tag IS present
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a new stage to test building docker images without uploading them... less clunky debugging

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will recommend to use wait-for-it to check port is opened.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agent is not being run, its just built and packaged so there's no port involved here

name: linux
os: linux
Expand All @@ -105,10 +114,8 @@ jobs:
env: APP_VERSION=${TRAVIS_TAG#v}

script:
# now we're going to create packages
- $TRAVIS_BUILD_DIR/scripts/ci_create_packages.sh
# upload packages to artifactory
- $TRAVIS_BUILD_DIR/scripts/ci_upload_packages.sh
# now we're going to create packages & upload packages
- $TRAVIS_BUILD_DIR/scripts/ci_create_packages.sh && $TRAVIS_BUILD_DIR/scripts/ci_upload_packages.sh
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ought to stop it from uploading if packages failed to be created


before_script:
# https://github.com/travis-ci/gimme
Expand Down
1 change: 1 addition & 0 deletions scripts/dockerfiles/Dockerfile.alpine
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ FROM golang:$GO_VERSION-alpine3.10 as builder
RUN apk add --no-cache make gcc libc-dev git
WORKDIR /go/src/github.com/optimizely/agent
COPY . .
RUN make install
RUN make build

FROM alpine:3.10
Expand Down
1 change: 1 addition & 0 deletions scripts/dockerfiles/Dockerfile.static
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ FROM golang:$GO_VERSION as builder

WORKDIR /go/src/github.com/optimizely/agent
COPY . .
RUN make install
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this drops in the new dependency on statik

RUN make ci_build_static_binary

FROM scratch
Expand Down