ci(travis): include statik dependency #201
Conversation
| # upload packages to artifactory | ||
| - $TRAVIS_BUILD_DIR/scripts/ci_upload_packages.sh | ||
| # now we're going to create packages & upload packages | ||
| - $TRAVIS_BUILD_DIR/scripts/ci_create_packages.sh && $TRAVIS_BUILD_DIR/scripts/ci_upload_packages.sh |
There was a problem hiding this comment.
this ought to stop it from uploading if packages failed to be created
| @@ -3,6 +3,7 @@ FROM golang:$GO_VERSION as builder | |||
|
|
|||
| WORKDIR /go/src/github.com/optimizely/agent | |||
| COPY . . | |||
| RUN make install | |||
There was a problem hiding this comment.
this drops in the new dependency on statik
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
- Coverage 82.11% 82.03% -0.09%
==========================================
Files 27 27
Lines 1230 1230
==========================================
- Hits 1010 1009 -1
- Misses 165 166 +1
Partials 55 55
Continue to review full report at Codecov.
|
| - export APP_VERSION=$(git describe --abbrev=0 --tags | tr -d '^v') | ||
| - $TRAVIS_BUILD_DIR/scripts/ci_create_packages.sh | ||
|
|
||
| - stage: Build and Upload | ||
| if: type = push AND tag IS present |
There was a problem hiding this comment.
added a new stage to test building docker images without uploading them... less clunky debugging
There was a problem hiding this comment.
I will recommend to use wait-for-it to check port is opened.
There was a problem hiding this comment.
agent is not being run, its just built and packaged so there's no port involved here
Summary
make installto the build Dockerfiles