deps: bump to k8s v1.17#2746
Merged
estroz merged 11 commits intooperator-framework:masterfrom Mar 31, 2020
Merged
Conversation
estroz
requested review from
camilamacedo86,
jmccormick2001,
jmrodri,
joelanford and
kevinrizza
openshift-ci-robot
added
the
area/dependency
*Update operator-registry dependency to 1.6.0 *Adds fix for generated dockerfiles *Adds optional output-directory parameter *Update cleanup funcs to handle new structure
operator-registry image builder but not generated by the SDK. In case deploy/olm-catalog/<operator-name>/manifests doesn't exist, create one and delete it after the image is done building. If --generate-only is set, do not remove manifests/. hack/tests: add 'bundle create' test cases doc,website: update generated CLI docs CHANGELOG.md: --output-dir addition and breaking change for bundle.Dockerfile location doc/migration: add breaking change to migration guide
This was referenced Mar 31, 2020
estroz
force-pushed
the
deps/k8s-1.17-registry-1.6.2
branch
from
9bfd942 to
955ba23
Compare
joelanford
reviewed
Mar 31, 2020
estroz
force-pushed
the
deps/k8s-1.17-registry-1.6.2
branch
from
da7c1f1 to
2d5ce1a
Compare
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
|
New changes are detected. LGTM label has been removed. |
estroz
force-pushed
the
deps/k8s-1.17-registry-1.6.2
branch
from
d3b7e3d to
ed8269b
Compare
joelanford
reviewed
Mar 31, 2020
Comment on lines
+5
to
+31
| function check_dir() { | ||
| if [[ $3 == 0 ]]; then | ||
| if [[ -d "$2" ]]; then | ||
| error_text "${1}: directory ${2} should not exist" | ||
| exit 1 | ||
| fi | ||
| else | ||
| if [[ ! -d "$2" ]]; then | ||
| error_text "${1}: directory ${2} should exist" | ||
| exit 1 | ||
| fi | ||
| fi | ||
| } | ||
|
|
||
| function check_file() { | ||
| if [[ $3 == 0 ]]; then | ||
| if [[ -f "$2" ]]; then | ||
| error_text "${1}: file ${2} should not exist" | ||
| exit 1 | ||
| fi | ||
| else | ||
| if [[ ! -f "$2" ]]; then | ||
| error_text "${1}: file ${2} should exist" | ||
| exit 1 | ||
| fi | ||
| fi | ||
| } |
Member
There was a problem hiding this comment.
Nit: move these to test_lib.sh?
Member
Author
There was a problem hiding this comment.
Will do that in #2737 when I add validate tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change: support new(er) version of k8s
Supercedes #2715, #2702
Fixes #2030
/area dependency