bundle validate: validate a bundle directory#2737
Merged
estroz merged 2 commits intooperator-framework:masterfrom Apr 1, 2020
Merged
bundle validate: validate a bundle directory#2737estroz merged 2 commits intooperator-framework:masterfrom
estroz merged 2 commits intooperator-framework:masterfrom
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
joelanford
reviewed
Mar 28, 2020
estroz
force-pushed
the
feature/bundle-validate-dir
branch
3 times, most recently
from
8683a26 to
14da6f9
Compare
estroz
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
estroz
force-pushed
the
feature/bundle-validate-dir
branch
from
5e74315 to
d19412c
Compare
Member
Author
|
Will rebase on top of #2746 and add test cases. /hold |
openshift-ci-robot
added
the
do-not-merge/hold
or an image arg hack/tests: add validate tests CHANGELOG.md: add bundle validate dir arg addition
estroz
force-pushed
the
feature/bundle-validate-dir
branch
from
d19412c to
9895b51
Compare
Member
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
camilamacedo86
approved these changes
Apr 1, 2020
Contributor
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
It is
/lgtm
/approve
for me.
jmccormick2001
approved these changes
Apr 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change: validate a directory of manifests by passing a directory as an arg nstead of an image tag.
Motivation for the change: So you don't have to build and push an image before validating its eventual contents.
TODO:
discuss CLI flags to make sure we want to make this breaking changewill do in [WIP] bundle: fixbundle create, bump operator-registry v1.6.0 #2715 since this fixes the bundle image builder/kind feature