Skip to content

🐛 Add prometheus network policy to network policy e2e #2043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

🐛 Add prometheus network policy to network policy e2e #2043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions test/e2e/network_policy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,27 @@ var denyAllPolicySpec = allowedPolicyDefinition{
denyAllEgressJustification: "Denies all egress traffic from pods selected by this policy by default, unless explicitly allowed by other policy rules, minimizing potential exfiltration paths.",
}

var prometheuSpec = allowedPolicyDefinition{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling error or intentional word play: prometheuSpec??

selector: metav1.LabelSelector{MatchLabels: map[string]string{"app.kubernetes.io/name": "prometheus"}},
policyTypes: []networkingv1.PolicyType{networkingv1.PolicyTypeIngress, networkingv1.PolicyTypeEgress},
ingressRule: ingressRule{
ports: []portWithJustification{
{
port: nil,
justification: "Allows access to the prometheus pod",
},
},
},
egressRule: egressRule{
ports: []portWithJustification{
{
port: nil,
justification: "Allows prometheus to access other pods",
},
},
},
}

// Ref: https://docs.google.com/document/d/1bHEEWzA65u-kjJFQRUY1iBuMIIM1HbPy4MeDLX4NI3o/edit?usp=sharing
var allowedNetworkPolicies = map[string]allowedPolicyDefinition{
"catalogd-controller-manager": {
Expand Down Expand Up @@ -163,6 +184,8 @@ func TestNetworkPolicyJustifications(t *testing.T) {
} else {
t.Log("Detected single-namespace configuration, expecting one 'default-deny-all-traffic' policy.")
allowedNetworkPolicies["default-deny-all-traffic"] = denyAllPolicySpec
t.Log("Detected single-namespace configuration, expecting 'prometheus' policy.")
allowedNetworkPolicies["prometheus"] = prometheuSpec
}

validatedRegistryPolicies := make(map[string]bool)
Expand Down