-
Couldn't load subscription status.
- Fork 68
🐛 Add prometheus network policy to network policy e2e #2043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Add prometheus network policy to network policy e2e #2043
Conversation
Signed-off-by: Todd Short <tshort@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This was due to stale tests… the Prometheus PR1928 was tested before the NetworkPolicies e2e PR2013 was merged, but merged after. PR1928 added a NetworkPolicy that PR2013 doesn’t know about, so the NetworkPolicy e2e fails. |
|
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
It seems that will pass now, I am ok with it since it will unblock the CI, We can improve if we wish to or need in a follow up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
assuming this is an upstream thing only
| denyAllEgressJustification: "Denies all egress traffic from pods selected by this policy by default, unless explicitly allowed by other policy rules, minimizing potential exfiltration paths.", | ||
| } | ||
|
|
||
| var prometheuSpec = allowedPolicyDefinition{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spelling error or intentional word play: prometheuSpec??
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, camilamacedo86, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2043 +/- ##
===========================================
+ Coverage 60.66% 73.87% +13.21%
===========================================
Files 81 81
Lines 7365 7365
===========================================
+ Hits 4468 5441 +973
+ Misses 2671 1584 -1087
- Partials 226 340 +114
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
10d8d79
into
operator-framework:main
Description
Reviewer Checklist