Skip to content

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Jun 24, 2025

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort requested a review from a team as a code owner June 24, 2025 14:57
@netlify
Copy link

netlify bot commented Jun 24, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 8b9eb8f
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/685abcd7b92c420008d32add
😎 Deploy Preview https://deploy-preview-2043--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci bot requested review from anik120 and grokspawn June 24, 2025 14:57
@tmshort
Copy link
Contributor Author

tmshort commented Jun 24, 2025

This was due to stale tests… the Prometheus PR1928 was tested before the NetworkPolicies e2e PR2013 was merged, but merged after. PR1928 added a NetworkPolicy that PR2013 doesn’t know about, so the NetworkPolicy e2e fails.

@tmshort
Copy link
Contributor Author

tmshort commented Jun 24, 2025

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2025
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

It seems that will pass now, I am ok with it since it will unblock the CI, We can improve if we wish to or need in a follow up.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2025
Copy link
Contributor

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

assuming this is an upstream thing only

denyAllEgressJustification: "Denies all egress traffic from pods selected by this policy by default, unless explicitly allowed by other policy rules, minimizing potential exfiltration paths.",
}

var prometheuSpec = allowedPolicyDefinition{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling error or intentional word play: prometheuSpec??

@openshift-ci
Copy link

openshift-ci bot commented Jun 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.87%. Comparing base (9380928) to head (8b9eb8f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2043       +/-   ##
===========================================
+ Coverage   60.66%   73.87%   +13.21%     
===========================================
  Files          81       81               
  Lines        7365     7365               
===========================================
+ Hits         4468     5441      +973     
+ Misses       2671     1584     -1087     
- Partials      226      340      +114     
Flag Coverage Δ
e2e 44.15% <ø> (?)
unit 60.65% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-merge-bot openshift-merge-bot bot merged commit 10d8d79 into operator-framework:main Jun 24, 2025
20 checks passed
@tmshort tmshort deleted the fix-net-policy-for-prom branch June 24, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants