-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 switch back to use of trusted CA, add extra test for mirror registry #1274
🌱 switch back to use of trusted CA, add extra test for mirror registry #1274
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to reviewers: review this with whitespace ignored. Most of the diff here is an indent of the original test code (just with templated package name).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a blank line issue, though.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1274 +/- ##
==========================================
- Coverage 76.51% 76.47% -0.05%
==========================================
Files 40 40
Lines 2363 2363
==========================================
- Hits 1808 1807 -1
- Misses 389 390 +1
Partials 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fix the lint, and I ought to be able to give it an LGTM. Looks like an undo and a test mod, as described. |
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
b6fdf68
to
8220aec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
33f6abf
This PR is intended to (partially) resolve issues around the complexity of implementing an e2e test that proves
/etc/containers/registries.conf
is honored.It:
registries.conf
in the standard e2e to map from a "mirrored-registry" to "docker-registry"ClusterExtensionInstallRegistry
e2e test to verify installs of both "prometheus" and the new "prometheus-mirrored" package (the latter would fail without the mapping config)Description
Reviewer Checklist