Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 switch back to use of trusted CA, add extra test for mirror registry #1274

Merged

Conversation

joelanford
Copy link
Member

This PR is intended to (partially) resolve issues around the complexity of implementing an e2e test that proves /etc/containers/registries.conf is honored.

It:

  • puts everything back to a registry with a trusted cert across the board
  • changes registries.conf in the standard e2e to map from a "mirrored-registry" to "docker-registry"
  • adds a new package in the shared catalog called "prometheus-mirrored" whose bundle ref uses the "mirror-registry" domain
  • updates the ClusterExtensionInstallRegistry e2e test to verify installs of both "prometheus" and the new "prometheus-mirrored" package (the latter would fail without the mapping config)

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford joelanford requested a review from a team as a code owner September 16, 2024 20:01
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 8220aec
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66e8935ca86aa20008bc2f72
😎 Deploy Preview https://deploy-preview-1274--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewers: review this with whitespace ignored. Most of the diff here is an indent of the original test code (just with templated package name).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a blank line issue, though.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.47%. Comparing base (f0c761d) to head (8220aec).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1274      +/-   ##
==========================================
- Coverage   76.51%   76.47%   -0.05%     
==========================================
  Files          40       40              
  Lines        2363     2363              
==========================================
- Hits         1808     1807       -1     
- Misses        389      390       +1     
  Partials      166      166              
Flag Coverage Δ
e2e 57.85% <ø> (ø)
unit 52.89% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshort
Copy link
Contributor

tmshort commented Sep 16, 2024

Fix the lint, and I ought to be able to give it an LGTM. Looks like an undo and a test mod, as described.

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford force-pushed the better-registries-conf-e2e-setup branch from b6fdf68 to 8220aec Compare September 16, 2024 20:21
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
@tmshort tmshort added this pull request to the merge queue Sep 16, 2024
Merged via the queue into operator-framework:main with commit 33f6abf Sep 16, 2024
17 of 18 checks passed
@joelanford joelanford deleted the better-registries-conf-e2e-setup branch September 17, 2024 00:21
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants