Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: separate unpacked bundles by name #1243

Merged

Conversation

joelanford
Copy link
Member

Description

Fixes a bug caused by not setting the BundleSource.Name during unpack. Without the fix, it means that:

  1. All cluster extension unpacking is happening in the same directory
  2. Because of (1), only the most recently reconciled bundle will have its FS extracted at once.
  3. Because of (2), when a ClusterExtension reconciles it has to re-pull and re-unpack its image if another ClusterExtension has reconciled in the meantime.
  4. (Not a problem today) If we turned on concurrent reconciles, then things would likely break even harder because the unpacker would be racing to delete the what it thinks are unused unpack paths while other reconciles are writing to them for other ClusterExtensions.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford joelanford requested a review from a team as a code owner September 10, 2024 12:05
Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 88ff438
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66e035ee02f3820008557135
😎 Deploy Preview https://deploy-preview-1243--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.54%. Comparing base (b29544b) to head (88ff438).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1243      +/-   ##
==========================================
+ Coverage   76.53%   76.54%   +0.01%     
==========================================
  Files          40       40              
  Lines        2340     2341       +1     
==========================================
+ Hits         1791     1792       +1     
  Misses        392      392              
  Partials      157      157              
Flag Coverage Δ
e2e 57.66% <100.00%> (+0.01%) ⬆️
unit 52.49% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelanford joelanford added this pull request to the merge queue Sep 10, 2024
Merged via the queue into operator-framework:main with commit bded2c2 Sep 10, 2024
18 checks passed
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
@joelanford joelanford deleted the add-name-to-bundlesource branch October 22, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants