-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Simplify status condition reasons #1241
✨ Simplify status condition reasons #1241
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1241 +/- ##
==========================================
- Coverage 76.53% 76.45% -0.09%
==========================================
Files 40 40
Lines 2340 2336 -4
==========================================
- Hits 1791 1786 -5
- Misses 392 393 +1
Partials 157 157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5f9ecb8
to
6d3af51
Compare
Signed-off-by: Catherine Chan-Tse <cchantse@redhat.com>
6d3af51
to
054e6b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
API diff is acceptable. |
871c883
Description
Simplifies status condition types per the v1 API Review RFC. Succeeded and Failed are used for all the status condition types (Unpacked, Installed, Resolved) to ensure consistency.
Fixes #1153
Reviewer Checklist