Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Simplify status condition reasons #1241

Merged

Conversation

oceanc80
Copy link
Contributor

@oceanc80 oceanc80 commented Sep 9, 2024

Description

Simplifies status condition types per the v1 API Review RFC. Succeeded and Failed are used for all the status condition types (Unpacked, Installed, Resolved) to ensure consistency.

Fixes #1153

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@oceanc80 oceanc80 requested a review from a team as a code owner September 9, 2024 23:15
Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 054e6b4
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66e04920cd2bf4000768c7e8
😎 Deploy Preview https://deploy-preview-1241--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.45%. Comparing base (0741d36) to head (054e6b4).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...nternal/controllers/clusterextension_controller.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1241      +/-   ##
==========================================
- Coverage   76.53%   76.45%   -0.09%     
==========================================
  Files          40       40              
  Lines        2340     2336       -4     
==========================================
- Hits         1791     1786       -5     
- Misses        392      393       +1     
  Partials      157      157              
Flag Coverage Δ
e2e 57.57% <62.50%> (-0.08%) ⬇️
unit 52.35% <87.50%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oceanc80 oceanc80 force-pushed the simplify-status-conditions branch 2 times, most recently from 5f9ecb8 to 6d3af51 Compare September 10, 2024 12:54
Signed-off-by: Catherine Chan-Tse <cchantse@redhat.com>
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
@tmshort
Copy link
Contributor

tmshort commented Sep 10, 2024

API diff is acceptable.

@tmshort tmshort added this pull request to the merge queue Sep 10, 2024
Merged via the queue into operator-framework:main with commit 871c883 Sep 10, 2024
18 of 19 checks passed
@oceanc80 oceanc80 deleted the simplify-status-conditions branch September 10, 2024 14:42
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify the reasons used in status conditions to only Succeeded and Failed
2 participants