-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump bingo + tools #1185
🌱 Bump bingo + tools #1185
Conversation
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1185 +/- ##
=======================================
Coverage 77.55% 77.55%
=======================================
Files 35 35
Lines 1916 1916
=======================================
Hits 1486 1486
Misses 296 296
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
6a7583a
to
71938d2
Compare
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
71938d2
to
59c0c3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the .bingo/README.md
file to clearly indicate that the bingo
commands should be run from the root of the repo? This was causing me such pain when I was trying to update setup-envtest
.
verbs: | ||
- list | ||
- watch | ||
- apiGroups: | ||
- olm.operatorframework.io | ||
resources: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh whoops - must have been changes that were already present? thank you!!
I'm not entirely sure. I just regenerated the manifests after controller-gen to bumped to 0.16.1. This was done automagically by the tool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as we're sure it was done automatically by the tooling, that's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah… it appears to be combining catalogmetadata
and clustercatalog
into one “stanza”, since they share properties.
But diff
don't make it easy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
a21829e
Description
Updates all tools under .bingo to latest and adds
bingo-upgrade
makefileReviewer Checklist