Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 update general/product documentation #1135

Merged

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Aug 16, 2024

Closes #1122

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva perdasilva requested a review from a team as a code owner August 16, 2024 17:32
Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit e805da5
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66c36e64a4e7b600088965f7
😎 Deploy Preview https://deploy-preview-1135--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.44%. Comparing base (368fd7c) to head (e805da5).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1135   +/-   ##
=======================================
  Coverage   75.44%   75.44%           
=======================================
  Files          35       35           
  Lines        1918     1918           
=======================================
  Hits         1447     1447           
  Misses        329      329           
  Partials      142      142           
Flag Coverage Δ
e2e 58.18% <ø> (ø)
unit 50.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@perdasilva perdasilva added documentation Improvements or additions to documentation kind/documentation Categorizes issue or PR as related to documentation. labels Aug 16, 2024
@perdasilva
Copy link
Contributor Author

@michaelryanpeter =D

docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated

In the dependency model, extensions can rely on each other for required services that are out of scope of the primary purpose of an extension, allowing each extension to focus on a specific purpose.
* get installed, potentially causing other dependency extensions to be installed as well
Copy link
Member

@LalatenduMohanty LalatenduMohanty Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the impression that we are not doing any dependency resolution as part of OLM 1.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's our highest priority, but, I also don't think it's been completely ruled out ^^ (I'm sure PM really wants it XD)

docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
@perdasilva
Copy link
Contributor Author

@adellape thank you, Alex!!!

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Copy link
Contributor

@michaelryanpeter michaelryanpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you questions about any of my comments.

docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated
Comment on lines 30 to 26
OLM (v0) has been in production for over 5 years, and the community to leverage this experience and question the initial
goals and assumptions of the project. OLM v1 is a complete redesign and rewrite of OLM taking into account this accumulated experience.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment on lines +27 to +33
Compared to its predecessor, amongst other things, OLM v1 aims to provide:
* A simpler API surface and mental model
* Less opinionated automation and greater flexibility
* Support for Kubernetes applications beyond only Operators
* Security by default
* Helm Chart support
* GitOps support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be better dealt with in a follow up issue, but I feel like we are burying the lead here.

I think it might be better to lead with what OLM v1 is, and make this block the second paragraph (line 8). Then we can go into the history of OLM v0 and the differences in scope.
If that is too much of a pivot, I'd be up for tweaking this in a follow up issue/PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's push that effort to a different PR. It should mostly be rejiggering order, I'd say.

perdasilva and others added 6 commits August 19, 2024 12:53
Co-authored-by: Michael Peter <mipeter@redhat.com>
Co-authored-by: Michael Peter <mipeter@redhat.com>
Co-authored-by: Michael Peter <mipeter@redhat.com>
Co-authored-by: Alex Dellapenta <adellape@redhat.com>
Co-authored-by: Michael Peter <mipeter@redhat.com>
Co-authored-by: Michael Peter <mipeter@redhat.com>
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks great to me!

Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Per

@michaelryanpeter
Copy link
Contributor

LGTM.

@everettraven everettraven added this pull request to the merge queue Aug 20, 2024
Merged via the queue into operator-framework:main with commit 1fb6bd2 Aug 20, 2024
18 checks passed
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: General/Product
5 participants