Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 labels: use consistent format for keys #1096

Merged

Conversation

joelanford
Copy link
Member

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford requested a review from a team as a code owner August 6, 2024 21:13
Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 0502146
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66b291f095cb7b0008341a9b
😎 Deploy Preview https://deploy-preview-1096--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.28%. Comparing base (cb9ea00) to head (0502146).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1096   +/-   ##
=======================================
  Coverage   75.28%   75.28%           
=======================================
  Files          35       35           
  Lines        1914     1914           
=======================================
  Hits         1441     1441           
  Misses        330      330           
  Partials      143      143           
Flag Coverage Δ
e2e 57.36% <ø> (ø)
unit 50.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gallettilance gallettilance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2024
@joelanford joelanford added this pull request to the merge queue Aug 7, 2024
Merged via the queue into operator-framework:main with commit baac660 Aug 7, 2024
18 checks passed
@joelanford joelanford deleted the consistent-label-format branch August 7, 2024 11:48
perdasilva pushed a commit to LalatenduMohanty/operator-controller that referenced this pull request Aug 13, 2024
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
perdasilva pushed a commit to kevinrizza/operator-controller that referenced this pull request Aug 13, 2024
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants