Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Use x509.CertPools instead of PEM strings #1052

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jul 15, 2024

Fixes #999

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner July 15, 2024 17:53
Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 8c148f2
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66957c8103a6d4000815e001
😎 Deploy Preview https://deploy-preview-1052--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 56.81818% with 19 lines in your changes missing coverage. Please review.

Project coverage is 72.63%. Comparing base (bfc65ee) to head (8c148f2).

Files Patch % Lines
internal/httputil/httputil.go 50.00% 10 Missing and 6 partials ⚠️
cmd/manager/main.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1052      +/-   ##
==========================================
- Coverage   72.98%   72.63%   -0.36%     
==========================================
  Files          28       28              
  Lines        1877     1889      +12     
==========================================
+ Hits         1370     1372       +2     
- Misses        375      381       +6     
- Partials      132      136       +4     
Flag Coverage Δ
e2e 54.19% <56.81%> (-0.15%) ⬇️
unit 45.36% <6.81%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Todd Short <tshort@redhat.com>
Merged via the queue into operator-framework:main with commit 87d97f2 Jul 15, 2024
16 of 18 checks passed
@tmshort tmshort deleted the fix-pem branch July 15, 2024 20:15
perdasilva pushed a commit to LalatenduMohanty/operator-controller that referenced this pull request Aug 13, 2024
Signed-off-by: Todd Short <tshort@redhat.com>
perdasilva pushed a commit to kevinrizza/operator-controller that referenced this pull request Aug 13, 2024
Signed-off-by: Todd Short <tshort@redhat.com>
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup use of PEM with certificates
2 participants