Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠ Move all packages from /pkg to /internal #1043

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

kevinrizza
Copy link
Member

Ahead of an initial 1.0.0 release, we shouldn't preemptively expose any packages publicly. Instead, let's start my making any packages internal, and we can expose them publicly later on. This commit moves everything currently in /pkg to /internal for now.

@kevinrizza kevinrizza requested a review from a team as a code owner July 12, 2024 14:28
Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 58c17e1
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66bb74f386ffbc0008289354
😎 Deploy Preview https://deploy-preview-1043--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.44%. Comparing base (c48e446) to head (58c17e1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1043   +/-   ##
=======================================
  Coverage   75.44%   75.44%           
=======================================
  Files          35       35           
  Lines        1918     1918           
=======================================
  Hits         1447     1447           
  Misses        329      329           
  Partials      142      142           
Flag Coverage Δ
e2e 58.18% <ø> (ø)
unit 50.78% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshort
Copy link
Contributor

tmshort commented Jul 12, 2024

We have a bunch of other commits (i.e. @dtfranz's import of rukpak) that we may want to wait on before we do this.

@tmshort
Copy link
Contributor

tmshort commented Jul 12, 2024

@kevinrizza, this needs to be rebased as #1032 was merged

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2024
@tmshort
Copy link
Contributor

tmshort commented Jul 26, 2024

@kevinrizza are you going update this?

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2024
@tmshort
Copy link
Contributor

tmshort commented Aug 13, 2024

Yeah, the location of a number of import lines changed, and this is causing lint problems.

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva
Copy link
Contributor

Yeah, the location of a number of import lines changed, and this is causing lint problems.

Fixed ^^

Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
API diff is expected as components are being moved from pkg to internal

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2024
@tmshort tmshort added this pull request to the merge queue Aug 13, 2024
Merged via the queue into operator-framework:main with commit 368fd7c Aug 13, 2024
17 of 18 checks passed
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants