Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Fixes and Improvements for TokenGetter #1014

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

skattoju
Copy link
Contributor

@skattoju skattoju commented Jul 5, 2024

Description

Fixes for some issues that were over looked in #1006 including:

  • Fixed unintentional integer division when rotating tokens
  • Fixed populating TokenRequest.Spec with nanoseconds instead of seconds
  • Removing the parameter that controls the duration after which expired tokens should be deleted and instead deleting them as soon as they are encountered

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@skattoju skattoju requested a review from a team as a code owner July 5, 2024 18:15
Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 019603d
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66883837e1150f000859c391
😎 Deploy Preview https://deploy-preview-1014--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@skattoju skattoju changed the title Fixes and Improvemens for TokenGetter ✨ Fixes and Improvements for TokenGetter Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.00%. Comparing base (5c83e91) to head (019603d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1014      +/-   ##
==========================================
- Coverage   78.07%   78.00%   -0.08%     
==========================================
  Files          18       18              
  Lines        1254     1250       -4     
==========================================
- Hits          979      975       -4     
  Misses        193      193              
  Partials       82       82              
Flag Coverage Δ
e2e 56.54% <ø> (ø)
unit 53.60% <100.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@everettraven everettraven added this pull request to the merge queue Jul 5, 2024
Merged via the queue into operator-framework:main with commit 7cc9872 Jul 5, 2024
17 of 19 checks passed
perdasilva pushed a commit to LalatenduMohanty/operator-controller that referenced this pull request Aug 13, 2024
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants