Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring streams and storage #25

Merged
merged 84 commits into from
Aug 23, 2019
Merged

Refactoring streams and storage #25

merged 84 commits into from
Aug 23, 2019

Conversation

jeqo
Copy link
Collaborator

@jeqo jeqo commented Aug 9, 2019

This PR is attempting to simplify Kafka Streams design and removing the need for an additional Lucene store.

Changes:

  • Topics has been reduced to 3:
    • spans (partitioned by traceId),
    • traces (partitioned by traceId), and
    • dependency-links (partitioned by pair parent:child)
  • Kafka Streams topologies reduced to 2, 1 for aggregation, 1 for storage:
    • trace-aggregation: key topology to collect spans, aggregate, and emit traces and dependency links. Based on Session window.
    • trace-store: Stores for traces (Key value store), service names (Key value store), and dependency links (Time window based store).
  • Lucene full-index replaced by a time-based index (based on key-value store) to first get ids, and then apply filtering. [TODO: test performance]. This approach keeps the same limitation for stores: Only standalone instance supported.
  • Kafka Streams unit-testing added.
  • Autocomplete tags support added.

@codefromthecrypt
Copy link
Contributor

possible to add autocomplete tag support?

@jeqo
Copy link
Collaborator Author

jeqo commented Aug 10, 2019

possible to add autocomplete tag support?

added :)

@codefromthecrypt
Copy link
Contributor

this might need a little work when you update to zipkin 2.16 because we changed the integration tests to jupiter

@jeqo
Copy link
Collaborator Author

jeqo commented Aug 21, 2019

@adriancole I've created openzipkin/zipkin#2762 and openzipkin/zipkin-reporter-java#158 to follow up some of the ideas we've discussed. Is there anything else missing from your pov?

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most comments of importance are around changing single-span message to list span message even when same traceID

Makefile Show resolved Hide resolved
autoconfigure/README.md Outdated Show resolved Hide resolved
autoconfigure/README.md Outdated Show resolved Hide resolved
autoconfigure/README.md Outdated Show resolved Hide resolved
autoconfigure/README.md Outdated Show resolved Hide resolved
autoconfigure/README.md Outdated Show resolved Hide resolved
autoconfigure/pom.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Te lo mereces un par de chelas!

@jeqo
Copy link
Collaborator Author

jeqo commented Aug 23, 2019 via email

@jeqo jeqo merged commit 3e9458d into master Aug 23, 2019
@codefromthecrypt
Copy link
Contributor

codefromthecrypt commented Aug 23, 2019 via email

@jeqo
Copy link
Collaborator Author

jeqo commented Aug 23, 2019 via email

@jeqo jeqo deleted the develop branch October 21, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants