-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring streams and storage #25
Conversation
one for aggregation and another for store
possible to add autocomplete tag support? |
added :) |
this might need a little work when you update to zipkin 2.16 because we changed the integration tests to jupiter |
autoconfigure/src/test/java/zipkin2/storage/kafka/ZipkinKafkaStorageAutoConfigurationTest.java
Outdated
Show resolved
Hide resolved
@adriancole I've created openzipkin/zipkin#2762 and openzipkin/zipkin-reporter-java#158 to follow up some of the ideas we've discussed. Is there anything else missing from your pov? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most comments of importance are around changing single-span message to list span message even when same traceID
Co-Authored-By: Adrian Cole <adriancole@users.noreply.github.com>
...onfigure/src/main/java/zipkin2/autoconfigure/storage/kafka/ZipkinKafkaStorageProperties.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Te lo mereces un par de chelas!
Solo un par? 😂🍻
…On Fri, 23 Aug 2019 at 11:42, Adrian Cole ***@***.***> wrote:
***@***.**** approved this pull request.
Te lo mereces un par de chelas!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#25>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABPE6XMO4U6GTF3QGS4N4S3QF6WJRANCNFSM4IKTYNTQ>
.
|
un par significa ocho, ya?
On Fri, Aug 23, 2019, 5:46 PM Jorge Quilcate Otoya <notifications@github.com>
wrote:
… Solo un par? 😂🍻
On Fri, 23 Aug 2019 at 11:42, Adrian Cole ***@***.***>
wrote:
> ***@***.**** approved this pull request.
>
> Te lo mereces un par de chelas!
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <
#25
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/ABPE6XMO4U6GTF3QGS4N4S3QF6WJRANCNFSM4IKTYNTQ
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAPVVZMPEX3IGATZASKMLLQF6WXHANCNFSM4IKTYNTQ>
.
|
Ahora si nos entendemos 😂😂😂
…On Fri, 23 Aug 2019 at 12:01, Adrian Cole ***@***.***> wrote:
un par significa ocho, ya?
On Fri, Aug 23, 2019, 5:46 PM Jorge Quilcate Otoya <
***@***.***>
wrote:
> Solo un par? 😂🍻
>
> On Fri, 23 Aug 2019 at 11:42, Adrian Cole ***@***.***>
> wrote:
>
> > ***@***.**** approved this pull request.
> >
> > Te lo mereces un par de chelas!
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub
> > <
>
#25
> >,
> > or mute the thread
> > <
>
https://github.com/notifications/unsubscribe-auth/ABPE6XMO4U6GTF3QGS4N4S3QF6WJRANCNFSM4IKTYNTQ
> >
> > .
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#25
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AAAPVVZMPEX3IGATZASKMLLQF6WXHANCNFSM4IKTYNTQ
>
> .
>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#25>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABPE6XP5KU4OWCZ3ZQTTBTLQF6YRHANCNFSM4IKTYNTQ>
.
|
This PR is attempting to simplify Kafka Streams design and removing the need for an additional Lucene store.
Changes:
spans
(partitioned bytraceId
),traces
(partitioned bytraceId
), anddependency-links
(partitioned by pairparent:child
)trace-aggregation
: key topology to collect spans, aggregate, and emit traces and dependency links. Based on Session window.trace-store
: Stores for traces (Key value store), service names (Key value store), and dependency links (Time window based store).