Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to zipkin's kafka test image? #26

Closed
codefromthecrypt opened this issue Aug 10, 2019 · 1 comment
Closed

switch to zipkin's kafka test image? #26

codefromthecrypt opened this issue Aug 10, 2019 · 1 comment

Comments

@codefromthecrypt
Copy link
Contributor

https://github.com/jeqo/zipkin-storage-kafka/blob/master/docker-compose.yml I see a few docker images and not sure for example, the manager is required. Seems faster to start with the kafka-zk image we have? Similarly, it is possible to switch the dockerfile to the distroless approach from upstream? If nothing else, this will reduce the differences and allow for apples/apples comparison. We could still have a separate file like docker-compose-confluent for a more prod thing of kafka side of it.

@jeqo
Copy link
Collaborator

jeqo commented Aug 23, 2019

Fixed by #25

@jeqo jeqo closed this as completed Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants