Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to c++17 #819

Merged
merged 12 commits into from
Sep 25, 2023
Merged

Move to c++17 #819

merged 12 commits into from
Sep 25, 2023

Commits on Aug 30, 2023

  1. Move to c++17. 

    All our compilers should handle c++17. Let's move on.
    @mgautierfr
    mgautierfr committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    c7853df View commit details
    Browse the repository at this point in the history

  2. Add missing include. 

    `uint32_t` is defined in `cstdint`.
    @mgautierfr
    mgautierfr committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    719a61c View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2023

  1. Do not inherit from std::iterator. 

    `std::iterator` is deprecated in c++17.
    @mgautierfr
    mgautierfr committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    56b1d9e View commit details
    Browse the repository at this point in the history

  2. Add werror=true

    @mgautierfr
    mgautierfr committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    0d9ec3f View commit details
    Browse the repository at this point in the history

  3. Compare unsigned with unsigned.

    @mgautierfr
    mgautierfr committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    d6dcf11 View commit details
    Browse the repository at this point in the history

  4. Remove unused variable.

    @mgautierfr
    mgautierfr committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    9c88842 View commit details
    Browse the repository at this point in the history

  5. No implicit conversion double to int.

    @mgautierfr
    mgautierfr committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    163b02b View commit details
    Browse the repository at this point in the history

  6. Explicit cast of -1 to zsize_t

    @mgautierfr
    mgautierfr committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    c3600ea View commit details
    Browse the repository at this point in the history

  7. No ignoring return value

    @mgautierfr
    mgautierfr committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    94bd1db View commit details
    Browse the repository at this point in the history

  8. Do not try to build subproject zstd with werror.

    @mgautierfr
    mgautierfr committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    681fde1 View commit details
    Browse the repository at this point in the history

  9. Fix the lib_postfix for aarch64

    @mgautierfr
    mgautierfr committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    9b21919 View commit details
    Browse the repository at this point in the history

  10. Define function use with WITH_TEST_DATA only if WITH_TEST_DATA. 

    Or else, they will be detected as defined but not used.
    @mgautierfr
    mgautierfr committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    51947a8 View commit details
    Browse the repository at this point in the history