Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to c++17 #819

Merged
merged 12 commits into from
Sep 25, 2023
Merged

Move to c++17 #819

merged 12 commits into from
Sep 25, 2023

Conversation

mgautierfr
Copy link
Collaborator

Fix #757

All our compilers should handle c++17. Let's move on.

This PR also (re)add werror=true and fix different warnings (raised differently by different compilers)

All our compilers should handle c++17. Let's move on.
`uint32_t` is defined in `cstdint`.
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: +0.05% 🎉

Comparison is base (66b3b7f) 57.47% compared to head (51947a8) 57.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #819      +/-   ##
==========================================
+ Coverage   57.47%   57.53%   +0.05%     
==========================================
  Files          98       98              
  Lines        4541     4540       -1     
  Branches     1910     1907       -3     
==========================================
+ Hits         2610     2612       +2     
  Misses        674      674              
+ Partials     1257     1254       -3     
Files Changed Coverage Δ
include/zim/archive.h 94.82% <ø> (ø)
src/cluster.cpp 35.29% <ø> (+0.51%) ⬆️
src/fileimpl.cpp 47.95% <ø> (ø)
src/tools.cpp 53.65% <0.00%> (ø)
src/writer/contentProvider.cpp 58.33% <0.00%> (ø)
include/zim/search_iterator.h 100.00% <100.00%> (ø)
include/zim/suggestion_iterator.h 87.50% <100.00%> (ø)
src/writer/dirent.cpp 60.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgautierfr mgautierfr marked this pull request as draft August 31, 2023 08:52
@mgautierfr mgautierfr marked this pull request as ready for review August 31, 2023 09:36
include/zim/archive.h Show resolved Hide resolved
include/zim/search_iterator.h Outdated Show resolved Hide resolved
include/zim/suggestion_iterator.h Outdated Show resolved Hide resolved
include/zim/suggestion_iterator.h Outdated Show resolved Hide resolved
test/counterParsing.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@veloman-yunkan veloman-yunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving. Fixup commits must be squashed. Squashup commits (if any) must be fixed.

@mgautierfr mgautierfr merged commit bd8f79c into main Sep 25, 2023
29 of 30 checks passed
@mgautierfr mgautierfr deleted the cpp17 branch September 25, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gtest C++14 requirement
2 participants