Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated line in test/error_in_creator. #776

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Conversation

mgautierfr
Copy link
Collaborator

Adding twice the same entry (metadata or not) will throw a exception. But we are testing async error here.
If the async error not thrown in time because the writer thread is "slow", we will not catch the async error in time and we will throw the "wrong" exception.

Should fix #775

Adding twice the same entry (metadata or not) will throw a exception.
But we are testing async error here.
If the async error not thrown in time because the writer thread is "slow",
we will not catch the async error in time and we will throw the "wrong"
exception.

Should fix #775
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6e31b4b) 84.30% compared to head (2e300dd) 84.30%.

❗ Current head 2e300dd differs from pull request most recent head 5db399f. Consider uploading reports for the commit 5db399f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #776   +/-   ##
=======================================
  Coverage   84.30%   84.30%           
=======================================
  Files         101      101           
  Lines        4627     4627           
  Branches     2004     2001    -3     
=======================================
  Hits         3901     3901           
  Misses        725      725           
  Partials        1        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@veloman-yunkan veloman-yunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could have questioned why you chose to delete line 294 rather than line 293, but I won't :)

@kelson42 kelson42 merged commit 6b21316 into main Apr 5, 2023
@kelson42 kelson42 deleted the fix_creator_test branch April 5, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Libzim does not compile (anymore?) on MIPS
3 participants