Libzim does not compile (anymore?) on MIPS

[kelson42]

Here is the feedback from the Debian CI

 * Source package: zimlib
 * Version: 8.1.1-0.2
 * Architecture: mipsel
 * State: failed
 * Suite: sid
 * Builder: mipsel-aql-01.debian.org
 * Build log: https://buildd.debian.org/status/fetch.php?pkg=zimlib&arch=mipsel&ver=8.1.1-0.2&stamp=1680384722&file=log

Please note that these notifications do not necessarily mean bug reports
in your package but could also be caused by other packages, temporary
uninstallabilities and arch-specific breakages.  A look at the build log
despite this disclaimer would be appreciated however.

and

 * Source package: zimlib
 * Version: 8.1.1-0.2
 * Architecture: mipsel
 * State: failed
 * Suite: sid
 * Builder: eberlin.debian.org
 * Build log: https://buildd.debian.org/status/fetch.php?pkg=zimlib&arch=mipsel&ver=8.1.1-0.2&stamp=1680382596&file=log

Please note that these notifications do not necessarily mean bug reports
in your package but could also be caused by other packages, temporary
uninstallabilities and arch-specific breakages.  A look at the build log
despite this disclaimer would be appreciated however.

[mgautierfr]

Error is:

test:         error_in_creator
start time:   21:30:41
duration:     58.47s
result:       exit status 1
command:      LD_LIBRARY_PATH=/<<PKGBUILDDIR>>/obj-mipsel-linux-gnu/src ZIM_TEST_DATA_DIR=none MALLOC_PERTURB_=141 /<<PKGBUILDDIR>>/obj-mipsel-linux-gnu/test/error_in_creator
----------------------------------- stdout -----------------------------------
Running main() from ./googletest/src/gtest_main.cc
[==========] Running 34 tests from 2 test suites.
[----------] Global test environment set-up.
[----------] 7 tests from CreatorError/FaultyItemErrorTest
[ RUN      ] CreatorError/FaultyItemErrorTest.faultyItem/0
Resolve redirect
set index
[       OK ] CreatorError/FaultyItemErrorTest.faultyItem/0 (2140 ms)
[ RUN      ] CreatorError/FaultyItemErrorTest.faultyItem/1
Resolve redirect
set index
[       OK ] CreatorError/FaultyItemErrorTest.faultyItem/1 (2534 ms)
[ RUN      ] CreatorError/FaultyItemErrorTest.faultyItem/2
Resolve redirect
set index
[       OK ] CreatorError/FaultyItemErrorTest.faultyItem/2 (4739 ms)
[ RUN      ] CreatorError/FaultyItemErrorTest.faultyItem/3
Resolve redirect
set index
[       OK ] CreatorError/FaultyItemErrorTest.faultyItem/3 (3752 ms)
[ RUN      ] CreatorError/FaultyItemErrorTest.faultyItem/4
Resolve redirect
set index
[       OK ] CreatorError/FaultyItemErrorTest.faultyItem/4 (2931 ms)
[ RUN      ] CreatorError/FaultyItemErrorTest.faultyItem/5
Resolve redirect
set index
[       OK ] CreatorError/FaultyItemErrorTest.faultyItem/5 (3596 ms)
[ RUN      ] CreatorError/FaultyItemErrorTest.faultyItem/6
Resolve redirect
set index
[       OK ] CreatorError/FaultyItemErrorTest.faultyItem/6 (4370 ms)
[----------] 7 tests from CreatorError/FaultyItemErrorTest (24081 ms total)

[----------] 27 tests from CreatorError/FaultyDelayedItemErrorTest
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyCompressedItem/0
../test/error_in_creator.cpp:294: Failure
Failed
An exception other than CreatorStateError or AsyncError was thrown.
[  FAILED  ] CreatorError/FaultyDelayedItemErrorTest.faultyCompressedItem/0, where GetParam() = 4-byte object <06-00 00-00> (14278 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyCompressedItem/1
../test/error_in_creator.cpp:294: Failure
Failed
An exception other than CreatorStateError or AsyncError was thrown.
[  FAILED  ] CreatorError/FaultyDelayedItemErrorTest.faultyCompressedItem/1, where GetParam() = 4-byte object <07-00 00-00> (3757 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyCompressedItem/2
../test/error_in_creator.cpp:294: Failure
Failed
An exception other than CreatorStateError or AsyncError was thrown.
[  FAILED  ] CreatorError/FaultyDelayedItemErrorTest.faultyCompressedItem/2, where GetParam() = 4-byte object <08-00 00-00> (3995 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyCompressedItem/3
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyCompressedItem/3 (2515 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyCompressedItem/4
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyCompressedItem/4 (2630 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyCompressedItem/5
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyCompressedItem/5 (1971 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyCompressedItem/6
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyCompressedItem/6 (1592 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyCompressedItem/7
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyCompressedItem/7 (1475 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyCompressedItem/8
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyCompressedItem/8 (1499 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyUnCompressedItem/0
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyUnCompressedItem/0 (30 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyUnCompressedItem/1
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyUnCompressedItem/1 (30 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyUnCompressedItem/2
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyUnCompressedItem/2 (30 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyUnCompressedItem/3
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyUnCompressedItem/3 (29 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyUnCompressedItem/4
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyUnCompressedItem/4 (31 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyUnCompressedItem/5
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyUnCompressedItem/5 (31 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyUnCompressedItem/6
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyUnCompressedItem/6 (31 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyUnCompressedItem/7
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyUnCompressedItem/7 (31 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyUnCompressedItem/8
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyUnCompressedItem/8 (30 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyUnfinishedCreator/0
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyUnfinishedCreator/0 (24 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyUnfinishedCreator/1
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyUnfinishedCreator/1 (22 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyUnfinishedCreator/2
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyUnfinishedCreator/2 (22 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyUnfinishedCreator/3
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyUnfinishedCreator/3 (19 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyUnfinishedCreator/4
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyUnfinishedCreator/4 (18 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyUnfinishedCreator/5
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyUnfinishedCreator/5 (18 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyUnfinishedCreator/6
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyUnfinishedCreator/6 (19 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyUnfinishedCreator/7
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyUnfinishedCreator/7 (18 ms)
[ RUN      ] CreatorError/FaultyDelayedItemErrorTest.faultyUnfinishedCreator/8
[       OK ] CreatorError/FaultyDelayedItemErrorTest.faultyUnfinishedCreator/8 (18 ms)
[----------] 27 tests from CreatorError/FaultyDelayedItemErrorTest (34186 ms total)

[----------] Global test environment tear-down
[==========] 34 tests from 2 test suites ran. (58268 ms total)
[  PASSED  ] 31 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] CreatorError/FaultyDelayedItemErrorTest.faultyCompressedItem/0, where GetParam() = 4-byte object <06-00 00-00>
[  FAILED  ] CreatorError/FaultyDelayedItemErrorTest.faultyCompressedItem/1, where GetParam() = 4-byte object <07-00 00-00>
[  FAILED  ] CreatorError/FaultyDelayedItemErrorTest.faultyCompressedItem/2, where GetParam() = 4-byte object <08-00 00-00>

 3 FAILED TESTS

But we probably need a mips computer to test and debug. It will be difficult to do something with the current log.

[mgautierfr]

I wonder why we have two identical lines here : https://github.com/openzim/libzim/blob/main/test/error_in_creator.cpp#L293-L294 (introduced in this commit : 44c0d47)

If the multi-thread is a bit "slow", adding twice the same metadata will indeed throw a exception which is not related to CreatorStateError nor AsyncError.