Skip to content

Linux build: always use objtool #17401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

Linux build: always use objtool #17401

merged 1 commit into from
May 30, 2025
+0 −13

Conversation

AttilaFueloep
Copy link
Contributor

Motivation and Context

Closes #17364

Description

We silence objtool warnings on some object files using OBJECT_FILES_NON_STANDARD_some_file.o. Nowadays objtool is needed for CPU vulnerability mitigations and a lot more functionality so its use is desirable.

Just remove the OBJECT_FILES_NON_STANDARD definitions. A follow-up commit is needed to make the offending files standard and address the compile time warnings.

How Has This Been Tested?

Module build and install on AlmaLinux 9.6.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@AttilaFueloep AttilaFueloep force-pushed the zfs-always-use-objtool branch from 0dfadca to 1be5989 Compare May 29, 2025 21:04
@AttilaFueloep
Copy link
Contributor Author

Fixed commit typos.

@tonyhutter
Copy link
Contributor

Can you add a Closes #17364 to your commit message as well?

@AttilaFueloep
Linux build: always use objtool
3bd5b4b 
We silence `objtool` warnings on some object files using
`OBJECT_FILES_NON_STANDARD_some_file.o`. Nowadays `objtool` is
needed for CPU vulnerability mitigations and a lot more
functionality so its use is desirable.

Just remove the `OBJECT_FILES_NON_STANDARD` definitions. A follow-up
commit is needed to make the offending files standard and address
the compile time warnings.

Signed-off-by: Attila Fülöp <attila@fueloep.org>
Closes openzfs#17364
@AttilaFueloep AttilaFueloep force-pushed the zfs-always-use-objtool branch from 1be5989 to 3bd5b4b Compare May 29, 2025 21:14
@AttilaFueloep
Copy link
Contributor Author

Done.

@tonyhutter tonyhutter mentioned this pull request May 29, 2025
Merged
14 tasks
@behlendorf behlendorf merged commit 3084336 into openzfs:master May 30, 2025
23 of 24 checks passed
behlendorf pushed a commit to tonyhutter/zfs that referenced this pull request May 30, 2025
@AttilaFueloep @behlendorf
Linux build: always use objtool
c1848f7 
We silence `objtool` warnings on some object files using
`OBJECT_FILES_NON_STANDARD_some_file.o`. Nowadays `objtool` is
needed for CPU vulnerability mitigations and a lot more
functionality so its use is desirable.

Just remove the `OBJECT_FILES_NON_STANDARD` definitions. A follow-up
commit is needed to make the offending files standard and address
the compile time warnings.

Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Attila Fülöp <attila@fueloep.org>
Closes openzfs#17401
Closes openzfs#17364
AttilaFueloep added a commit to AttilaFueloep/zfs that referenced this pull request Jun 1, 2025
@AttilaFueloep
Linux build: silence objtool warnings
d58740d 
After openzfs#17401 the Linux build produces some stack related warnings.

Silence them with the `STACK_FRAME_NON_STANDARD` macro.

Signed-off-by: Attila Fülöp <attila@fueloep.org>
@AttilaFueloep AttilaFueloep mentioned this pull request Jun 1, 2025
Merged
14 tasks
AttilaFueloep added a commit to AttilaFueloep/zfs that referenced this pull request Jun 3, 2025
@AttilaFueloep @behlendorf
Linux build: silence objtool stack warnings
fa695c2 
After openzfs#17401 the Linux build produces some stack related warnings.

Silence them with the `STACK_FRAME_NON_STANDARD` macro.

Signed-off-by: Attila Fülöp <attila@fueloep.org>
Co-authored-by: Brian Behlendorf <behlendorf1@llnl.gov>
@AttilaFueloep AttilaFueloep mentioned this pull request Jun 4, 2025
Closed
behlendorf added a commit that referenced this pull request Jun 5, 2025
@AttilaFueloep @behlendorf
Linux build: silence objtool warnings
b96f1a4 
After #17401 the Linux build produces some stack related warnings.

Silence them with the `STACK_FRAME_NON_STANDARD` macro.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Signed-off-by: Attila Fülöp <attila@fueloep.org>
Co-authored-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #17410
behlendorf added a commit to tonyhutter/zfs that referenced this pull request Jun 5, 2025
@AttilaFueloep @behlendorf
Linux build: silence objtool warnings
b608b95 
After openzfs#17401 the Linux build produces some stack related warnings.

Silence them with the `STACK_FRAME_NON_STANDARD` macro.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Signed-off-by: Attila Fülöp <attila@fueloep.org>
Co-authored-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#17410
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jun 13, 2025
@AttilaFueloep @behlendorf
Linux build: always use objtool
1652a62 
We silence `objtool` warnings on some object files using
`OBJECT_FILES_NON_STANDARD_some_file.o`. Nowadays `objtool` is
needed for CPU vulnerability mitigations and a lot more
functionality so its use is desirable.

Just remove the `OBJECT_FILES_NON_STANDARD` definitions. A follow-up
commit is needed to make the offending files standard and address
the compile time warnings.

Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Attila Fülöp <attila@fueloep.org>
Closes openzfs#17401
Closes openzfs#17364
behlendorf added a commit to behlendorf/zfs that referenced this pull request Jun 13, 2025
@AttilaFueloep @behlendorf
Linux build: silence objtool warnings
36979ee 
After openzfs#17401 the Linux build produces some stack related warnings.

Silence them with the `STACK_FRAME_NON_STANDARD` macro.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Signed-off-by: Attila Fülöp <attila@fueloep.org>
Co-authored-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#17410
behlendorf pushed a commit that referenced this pull request Jun 17, 2025
@AttilaFueloep @behlendorf
Linux build: always use objtool
3a39c2a 
We silence `objtool` warnings on some object files using
`OBJECT_FILES_NON_STANDARD_some_file.o`. Nowadays `objtool` is
needed for CPU vulnerability mitigations and a lot more
functionality so its use is desirable.

Just remove the `OBJECT_FILES_NON_STANDARD` definitions. A follow-up
commit is needed to make the offending files standard and address
the compile time warnings.

Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Attila Fülöp <attila@fueloep.org>
Closes #17401
Closes #17364
behlendorf added a commit that referenced this pull request Jun 17, 2025
@AttilaFueloep @behlendorf
Linux build: silence objtool warnings
d2de9c1 
After #17401 the Linux build produces some stack related warnings.

Silence them with the `STACK_FRAME_NON_STANDARD` macro.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Signed-off-by: Attila Fülöp <attila@fueloep.org>
Co-authored-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #17410
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jun 17, 2025
@AttilaFueloep @behlendorf
Linux build: always use objtool
2c53fe7 
We silence `objtool` warnings on some object files using
`OBJECT_FILES_NON_STANDARD_some_file.o`. Nowadays `objtool` is
needed for CPU vulnerability mitigations and a lot more
functionality so its use is desirable.

Just remove the `OBJECT_FILES_NON_STANDARD` definitions. A follow-up
commit is needed to make the offending files standard and address
the compile time warnings.

Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Attila Fülöp <attila@fueloep.org>
Closes openzfs#17401
Closes openzfs#17364
behlendorf added a commit to behlendorf/zfs that referenced this pull request Jun 17, 2025
@AttilaFueloep @behlendorf
Linux build: silence objtool warnings
e9c1e08 
After openzfs#17401 the Linux build produces some stack related warnings.

Silence them with the `STACK_FRAME_NON_STANDARD` macro.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Signed-off-by: Attila Fülöp <attila@fueloep.org>
Co-authored-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#17410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@mcmilk mcmilk mcmilk approved these changes

@tonyhutter tonyhutter tonyhutter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EL9.6: "Unpatched return thunk in use"
4 participants
@AttilaFueloep @tonyhutter @behlendorf @mcmilk