Skip to content

Commit 3a39c2a

Browse files
AttilaFueloepbehlendorf
authored andcommitted
Linux build: always use objtool
We silence `objtool` warnings on some object files using `OBJECT_FILES_NON_STANDARD_some_file.o`. Nowadays `objtool` is needed for CPU vulnerability mitigations and a lot more functionality so its use is desirable. Just remove the `OBJECT_FILES_NON_STANDARD` definitions. A follow-up commit is needed to make the offending files standard and address the compile time warnings. Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Attila Fülöp <attila@fueloep.org> Closes #17401 Closes #17364
1 parent cc41e3a commit 3a39c2a

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

module/Kbuild.in

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -176,14 +176,6 @@ $(addprefix $(obj)/icp/,$(ICP_OBJS) $(ICP_OBJS_X86) $(ICP_OBJS_X86_64) \
176176
$(addprefix $(obj)/icp/,$(ICP_OBJS) $(ICP_OBJS_X86) $(ICP_OBJS_X86_64) \
177177
$(ICP_OBJS_ARM64) $(ICP_OBJS_PPC_PPC64)) : ccflags-y += -I$(icp_include) -I$(zfs_include)/os/linux/spl -I$(zfs_include)
178178

179-
# Suppress objtool "return with modified stack frame" warnings.
180-
OBJECT_FILES_NON_STANDARD_aesni-gcm-x86_64.o := y
181-
182-
# Suppress objtool "unsupported stack pointer realignment" warnings.
183-
# See #6950 for the reasoning.
184-
OBJECT_FILES_NON_STANDARD_sha256-x86_64.o := y
185-
OBJECT_FILES_NON_STANDARD_sha512-x86_64.o := y
186-
187179
LUA_OBJS := \
188180
lapi.o \
189181
lauxlib.o \
@@ -499,11 +491,6 @@ UBSAN_SANITIZE_sa.o := n
499491
UBSAN_SANITIZE_zfs/zap_micro.o := n
500492
UBSAN_SANITIZE_zfs/sa.o := n
501493

502-
# Suppress incorrect warnings from versions of objtool which are not
503-
# aware of x86 EVEX prefix instructions used for AVX512.
504-
OBJECT_FILES_NON_STANDARD_vdev_raidz_math_avx512bw.o := y
505-
OBJECT_FILES_NON_STANDARD_vdev_raidz_math_avx512f.o := y
506-
507494
ifeq ($(CONFIG_ALTIVEC),y)
508495
$(obj)/zfs/vdev_raidz_math_powerpc_altivec.o : c_flags += -maltivec
509496
endif

0 commit comments

Comments
 (0)