rust: update to 1.73.0 #22380
rust: update to 1.73.0 #22380
Conversation
|
Also preparation to conversation started here about musl host support, but this just updates to 1.73.0. @Ansuel support provided by alpine is a bit too complex, I was never able to adopt it to openwrt packages. With 1.73.0 and libc patch, it worked like a charm with But this is just conversation about topic. Hopefully idea gets some hope, but let's update rust first. |
Doesn't hurt and since OpenWrt favours shared libraries it is future proof for when we'll have to consider other libcs. |
| let llvm_assertions = self.llvm_assertions; | ||
|
|
||
| let cache_prefix = format!("llvm-{}-{}", llvm_sha, llvm_assertions); | ||
| let cache_prefix = format!("llvm-{llvm_sha}-{llvm_assertions}"); | ||
| - let cache_dst = self.out.join("cache"); | ||
| + let cache_dst = match env::var_os("OPENWRT_RUSTC_BOOTSTRAP_CACHE") { |
There was a problem hiding this comment.
Probably we could float it towards upstream using a less os-specific name
There was a problem hiding this comment.
I'll put there whatever you want- that is just refreshed patch that appeared in previous package release update (1.72.0-3) without me doing any actual changes.
Should I then add it to this already? |
|
I'm fine with folding it in :) (and also your change for crt-static) |
|
Okay, thanks.. I'll make the necessary adjustment to PR.. |
patches refreshed. changelog at https://github.com/rust-lang/rust/releases/tag/1.73.0 Also added a configuration ardument and patch from https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-lang/rust/files/1.72.0-bump-libc-deps-to-0.2.146.patch?id=515b5920046117355d88b3494c74da269ce9b30a to provide support for building rust on musl hosts. Signed-off-by: Oskari Rauta <oskari.rauta@gmail.com> rust: add support for musl build hosts Signed-off-by: Oskari Rauta <oskari.rauta@gmail.com>
|
Where are we at with that os branding topic within patch 0002-rustc-bootstrap-cache.patch? |
|
Re: 0002-rustc-bootstrap-cache.patch - the bootstrap already "caches" downloaded files in the build directory. I imagine this is fine for normal users but for us the build directory is not persisted between builds. I'm not sure upstream would be interested in adding more customization (like an environment variable) for where to save this cache, but then again I never asked. |
|
I think it is a good idea overall, sometimes you may have more than a tree around even in other scenarios :) |
|
So, how do we proceed? |
|
I'd land this set, anybody willing to change the env name to |
I opened rust-lang/rust#116697. I think the patch here can stay as it is until if/when the change is merged upstream. |
|
Though I thought that I don't participate in decision about it, I have to say that I agree; maybe it's not topic of this PR. Do good. |
changelog at https://github.com/rust-lang/rust/releases/tag/1.73.0
Maintainer: @lu-zero
Compile tested: x86_64, latest git
Run tested: x86_64, latest git