-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST] Compare whole Tensor in Template Plugin tests #23408
[TEST] Compare whole Tensor in Template Plugin tests #23408
Conversation
Blocked by #23226 |
…e/test/compare-tensor
…e/test/compare-tensor
src/plugins/template/tests/functional/op_reference/adaptive_avg_pool.cpp
Show resolved
Hide resolved
"tile_1d_to_3d_with_zero_on_axis_0"), | ||
TileParams(reference_tests::Tensor(ET, {3}, std::vector<T>{1, 2, 3}), | ||
reference_tests::Tensor(ET_INT, {3}, std::vector<T_INT>{2, 0, 3}), | ||
reference_tests::Tensor(ET, {0}, std::vector<T>{}), | ||
reference_tests::Tensor(ET, {2, 0, 9}, std::vector<T>{}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why it is required? I expected tensor with no values should have shape == {0}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well .. shapes comparison fails otherwise. Should the comparison be improved? If so, I'll move this test back to legacy raw compare.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However this shape is produced by shape_infer
, so it should be consider valid. @praasz, what do think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tensor can have shape set with dimension 0
which will result as no data but still can have some dimension.
If these test validate all properties of the tensor like type, shape, data then it should be set what shape inference calculate for this operator (in this case Tile should not reduce rank.
There will be just no data to calculate/compare.
In my opinion this is OK as we check what Tile produce.
Maybe is not real scenario but Is possible to make this kind of Tile as sub-graph and gather first and/or last dimension(s) from Tile output make ShapeOf of it which can produce data like {2,9} which can be input for other operator.
…e/test/compare-tensor
…#23408) ### Details: - `ov::test::utils::compare(...)` used for output vs reference values comparison (where possible). - Tests with a need of complex changes were marked with `legacy_compare` flag. These tests still use legacy raw data comparison and theirs transition will be addressed in further PR's. ### Tickets: - CVS-135274, CVS-135275 --------- Co-authored-by: Michal Lukaszewski <michal.lukaszewski@intel.com>
…#23408) ### Details: - `ov::test::utils::compare(...)` used for output vs reference values comparison (where possible). - Tests with a need of complex changes were marked with `legacy_compare` flag. These tests still use legacy raw data comparison and theirs transition will be addressed in further PR's. ### Tickets: - CVS-135274, CVS-135275 --------- Co-authored-by: Michal Lukaszewski <michal.lukaszewski@intel.com>
Details:
ov::test::utils::compare(...)
used for output vs reference values comparison (where possible).legacy_compare
flag. These tests still use legacy raw data comparison and theirs transition will be addressed in further PR's.Tickets: