Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tmpl test] Bucketize: enable whole Tensor comparison #23769

Merged
merged 19 commits into from
Apr 11, 2024
Merged

[Tmpl test] Bucketize: enable whole Tensor comparison #23769

merged 19 commits into from
Apr 11, 2024

Conversation

t-jankowski
Copy link
Contributor

Details:

  • Used actual shapes for Tensors creation.

Tickets:

t-jankowski and others added 17 commits March 12, 2024 11:39
@t-jankowski
Enhance ref vs out data comparison in template test
74a6436
@t-jankowski
Enhance ref vs out data comparison in template test
213bfc0
@t-jankowski
Add Tensor comparizon
2bfcf1a
@t-jankowski
Enhance ref vs out data comparison in template test
b12e3a8
@t-jankowski
Keep legacy comparison
8c8cbff
@t-jankowski
Fix style
e15d719
@t-jankowski
Use legacy comparison for Tan ref test
01af380
@t-jankowski
Merge remote-tracking branch 'upstream/master' into tj/plugin/templat…
890ae27 
…e/test/compare-tensor
@t-jankowski
Merge remote-tracking branch 'upstream/master' into tj/plugin/templat…
dd10733 
…e/test/compare-tensor
@t-jankowski
Use leagcy comparison for MaxPool and Mish
e4d8f06
@t-jankowski
Merge remote-tracking branch 'upstream/master' into tj/plugin/templat…
719398e 
…e/test/compare-tensor
@mlukasze
Merge branch 'master' into tj/plugin/template/test/compare-tensor
e05e0b8
@t-jankowski
Merge branch 'master' into tj/plugin/template/test/compare-tensor
077af8a
@t-jankowski
Merge branch 'master' into tj/plugin/template/test/compare-tensor
5561073
@t-jankowski
Merge branch 'master' into tj/plugin/template/test/compare-tensor
6df849d
@t-jankowski
Merge remote-tracking branch 'upstream/master' into tj/plugin/templat…
7abbbd1 
…e/test/compare-tensor
@t-jankowski
Enable whole Tensor comparison
ce02aba
@github-actions github-actions bot added the category: TEMPLATE OpenVINO Template plugin label Mar 29, 2024
@t-jankowski
Copy link
Contributor Author

Depends on #23408.

@t-jankowski t-jankowski marked this pull request as ready for review April 4, 2024 07:29
@t-jankowski t-jankowski requested a review from a team as a code owner April 4, 2024 07:29
@t-jankowski t-jankowski requested a review from vurusovs April 4, 2024 07:29
@t-jankowski t-jankowski requested review from olpipi and praasz and removed request for a team April 5, 2024 09:41
@olpipi
Copy link
Contributor

olpipi commented Apr 5, 2024

Don't we plan to test dynamic scenarios here?

@t-jankowski
Copy link
Contributor Author

t-jankowski commented Apr 8, 2024 •
edited
Loading

Don't we plan to test dynamic scenarios here?

Template Plugin test bases on CommonReferenceTest which uses ov::Tensor and PartialShape brings no usage. All changed shapes were static.
To have dynamic test a new dedicate base class should be created, but I'm not aware of any plan for such test.

@t-jankowski t-jankowski added this pull request to the merge queue Apr 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 10, 2024
@t-jankowski t-jankowski added this pull request to the merge queue Apr 11, 2024
Merged via the queue into openvinotoolkit:master with commit 6a47174 Apr 11, 2024
113 checks passed
bbielawx pushed a commit to bbielawx/openvino that referenced this pull request Apr 12, 2024
@t-jankowski @mlukasze @bbielawx
[Tmpl test] Bucketize: enable whole Tensor comparison (openvinotoolki…
07dc3cb 
…t#23769)

### Details:
 - Used actual shapes for Tensors creation.

### Tickets:
 - CVS-137147

---------

Co-authored-by: Michal Lukaszewski <michal.lukaszewski@intel.com>
alvoron pushed a commit to alvoron/openvino that referenced this pull request Apr 29, 2024
@t-jankowski @mlukasze @alvoron
[Tmpl test] Bucketize: enable whole Tensor comparison (openvinotoolki…
446d63d 
…t#23769)

### Details:
 - Used actual shapes for Tensors creation.

### Tickets:
 - CVS-137147

---------

Co-authored-by: Michal Lukaszewski <michal.lukaszewski@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praasz praasz praasz approved these changes

@olpipi olpipi olpipi approved these changes

@vurusovs vurusovs Awaiting requested review from vurusovs

Assignees
No one assigned
Labels
category: TEMPLATE OpenVINO Template plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t-jankowski @olpipi @praasz @mlukasze