Refactored with single dispatch generic function implementation

[mahimairaja]

Details:

Added single dispatch generic function implementation

• torchvision_preprocessing.py Line 50

• torchvision_preprocessing.py Line 70

Tickets:

Refactor torchvision preprocessing converter into Python singledispatch
Closes #19912

[ilya-lavrenov]

build_jenkins

[mahimairaja]

I am new to jenkins, is there any docs to build jenkins...

[mlukasze]

I am new to jenkins, is there any docs to build jenkins...

Ilya's comment was in a fact command to run our Jenkins for you, so no, you don't have to do anything :)

[mahimairaja]

Gotcha!

[p-wysocki]

LGTM, thank you for your contribution!

@jiwaszki do you know if we can merge this PR before #19534 is merged? Python 3.7 does not have built-in singledispatch, but I see that data_dispatcher.py also doesn't do any magic with importing it, so I suppose this PR will work with Python 3.7, right? Until we get an answer, I'm putting on a do_not_merge label.

@mahimairaja could you please take a look at Python API checks? It seems that mypy is failing. Please keep in mind that if fixing the mypy issue isn't practical, skipping the line is an option too.

[mahimairaja]

Thank you @p-wysocki :)

[mahimairaja]

I am not sure, I added the return type and added the patches for linting only but the build has failed...

[p-wysocki]

@mahimairaja that seems like a sporadic Azure error, I restarted the pipeline.

[p-wysocki]

./src/openvino/preprocess/torchvision/torchvision_preprocessing.py:57:32: E261 at least two spaces before inline comment
    return int(size), int(size) # type: ignore

[mahimairaja]

Is the PR is good to go? @p-wysocki

[mlukasze]

Is the PR is good to go? @p-wysocki

we are waiting for last CI checks, but from code review perspective it looks like ready to merge :)

[p-wysocki]

There were some CI failures, but nothing on your side I think. I merged master, it helped on another PR with the same issue. Let's hope CI passes now.

[ilya-lavrenov]

build_jenkins

[jiwaszki]

LGTM, thank you for your contribution!

@jiwaszki do you know if we can merge this PR before #19534 is merged? Python 3.7 does not have built-in singledispatch, but I see that data_dispatcher.py also doesn't do any magic with importing it, so I suppose this PR will work with Python 3.7, right? Until we get an answer, I'm putting on a do_not_merge label.

@p-wysocki yes, it will work.

openvino/src/bindings/python/src/openvino/runtime/utils/data_helpers/wrappers.py

Lines 7 to 12 in 7d1b7b6

	# TODO: remove this WA and refactor OVDict when Python3.8
	# becomes minimal supported version.
	try:
	from functools import singledispatchmethod
	except ImportError:
	from singledispatchmethod import singledispatchmethod # type: ignore[no-redef]

-- only class methods are not "dispatchable" in <3.8.

I am going to remove the label.

[jiwaszki]

LGTM

[mahimairaja]

Thank you team :)