Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove openvino-dev dependency #2675

Merged
merged 7 commits into from
May 15, 2024
Merged

Conversation

kshpv
Copy link
Collaborator

@kshpv kshpv commented May 13, 2024

Changes

Remove openvino-dev dependency

Reason for changes

Remove potentially deprecated package

Related tickets

136314

Tests

N/A

@github-actions github-actions bot added NNCF TF Pull requests that updates NNCF TensorFlow NNCF PT Pull requests that updates NNCF PyTorch NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF ONNX Pull requests that updates NNCF ONNX NNCF PTQ Pull requests that updates NNCF PTQ labels May 13, 2024
@kshpv kshpv marked this pull request as ready for review May 13, 2024 11:59
@kshpv kshpv requested a review from a team as a code owner May 13, 2024 11:59
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.42%. Comparing base (cf73597) to head (d09110c).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2675       +/-   ##
============================================
- Coverage    62.05%   50.42%   -11.64%     
============================================
  Files          495      495               
  Lines        45973    45973               
============================================
- Hits         28530    23181     -5349     
- Misses       17443    22792     +5349     

see 97 files with indirect coverage changes

Flag Coverage Δ
COMMON ?
ONNX 34.71% <ø> (ø)
OPENVINO ?
TENSORFLOW 29.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 81.19% <ø> (-7.24%) ⬇️
torch 32.75% <ø> (-0.32%) ⬇️
tensorflow 93.74% <ø> (ø)
onnx 93.06% <ø> (ø)
openvino 0.00% <ø> (-94.16%) ⬇️
ptq 41.40% <ø> (-38.98%) ⬇️

@kshpv kshpv requested a review from alexsu52 May 13, 2024 13:33
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsu52 alexsu52 merged commit 66b381c into openvinotoolkit:develop May 15, 2024
12 checks passed
@kshpv kshpv mentioned this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF ONNX Pull requests that updates NNCF ONNX NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PT Pull requests that updates NNCF PyTorch NNCF PTQ Pull requests that updates NNCF PTQ NNCF TF Pull requests that updates NNCF TensorFlow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants