Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

[Bug]: Familiar time, error + familiar gone upon logout. #389

Closed
1 task done
joelslamospersson opened this issue Jan 22, 2022 · 1 comment · Fixed by #381
Closed
1 task done

[Bug]: Familiar time, error + familiar gone upon logout. #389

joelslamospersson opened this issue Jan 22, 2022 · 1 comment · Fixed by #381
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@joelslamospersson
Copy link

What happened?

Timer issue, img below:
https://gyazo.com/51906eee71f93a192b9b65e58249073e

How to Reproduce?

Change data\lib\tables\familiar.lua
From
for sendMessage = 1, #timer do
player:setStorageValue(timer[sendMessage].storage, -1)
end

to
for sendMessage = 1, #FAMILIAR_TIMER do
player:setStorageValue(FAMILIAR_TIMER[sendMessage].storage, -1)
end

Relevant log output

No response

Attach any relevant file

No response

Version

12.x (Default)

What OS are you seeing the problem on?

Ubuntu 20.04

Code of Conduct

  • I agree to follow this project's Code of Conduct
@joelslamospersson joelslamospersson added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 22, 2022
@travisani
Copy link
Contributor

function removeFamiliar(creatureId, playerId)
local creature = Creature(creatureId)
local player = Player(playerId)
if not creature or not player then
return true
end
creature:remove()
for sendMessage = 1, #FAMILIAR_TIMER do
player:setStorageValue(timer[sendMessage].storage, -1)
end
end

@dudantas dudantas mentioned this issue Jan 24, 2022
9 tasks
@dudantas dudantas linked a pull request Jan 24, 2022 that will close this issue
9 tasks
dudantas added a commit that referenced this issue Jan 26, 2022
Fix for the issue #380 and #389

- Variable "monster.summons" renamed to "monster.summon"
- Improved the "registerMonsterType.summon" function. The "monster.maxSummons" was changed to be inside "monster.summon", thus facilitating development
- Added new table "summons" inside of "monster.summon"
- Added the "count" in the "monsterType:addSummon" function
- Fixed somes summons with "Demon2" name to "Demon"
- Removed "monster.summonCost", the correct is "monster.manaCost"
- Fixed a bug in the "registerMonsterType.light" function
- Fixed bug in the familiar behavior
- Modified all monsters for new style of summons
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants