Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

[Bug]: Number of summons is exceeding the maximum stablished. #380

Closed
1 task done
tiothiago opened this issue Jan 14, 2022 · 3 comments · Fixed by #381
Closed
1 task done

[Bug]: Number of summons is exceeding the maximum stablished. #380

tiothiago opened this issue Jan 14, 2022 · 3 comments · Fixed by #381
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@tiothiago
Copy link

tiothiago commented Jan 14, 2022

What happened?

General Murius, for exemple, has a maximum number of Minotaur Guards set as 2. Same thing for Minotaur Archers.

Yet, it happens to be that General Murius is summuning up to 4 Minotaur Guards or 4 Minotaur Archers, clearly a bug somewhere in monster.cpp

How to Reproduce?

Just summon General Murius.

Relevant log output

No response

Attach any relevant file

unknown
unknown

Version

12.x (Default)

What OS are you seeing the problem on?

Windows 10

Code of Conduct

  • I agree to follow this project's Code of Conduct
@tiothiago tiothiago added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 14, 2022
@tiothiago
Copy link
Author

@dudantas
Copy link
Collaborator

Solution otland/forgottenserver@215713d#diff-62aa9c61dc49a0decc4065f0bf8a8038a56aea325a2c496a048e7657abd03cca

I think this is not the solution, possibly the solution is to fix the other function and not create a new one.

@dudantas dudantas mentioned this issue Jan 15, 2022
9 tasks
@dudantas dudantas linked a pull request Jan 15, 2022 that will close this issue
9 tasks
@dudantas
Copy link
Collaborator

@tiothiago, you can test the pr #381?

dudantas added a commit that referenced this issue Jan 26, 2022
Fix for the issue #380 and #389

- Variable "monster.summons" renamed to "monster.summon"
- Improved the "registerMonsterType.summon" function. The "monster.maxSummons" was changed to be inside "monster.summon", thus facilitating development
- Added new table "summons" inside of "monster.summon"
- Added the "count" in the "monsterType:addSummon" function
- Fixed somes summons with "Demon2" name to "Demon"
- Removed "monster.summonCost", the correct is "monster.manaCost"
- Fixed a bug in the "registerMonsterType.light" function
- Fixed bug in the familiar behavior
- Modified all monsters for new style of summons
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants