Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: gamestore cpp #2834

Open
wants to merge 47 commits into
base: main
Choose a base branch
from

fix: compilation with unity build

40b3414
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

feat: gamestore cpp #2834

fix: compilation with unity build
40b3414
Select commit
Loading
Failed to load commit list.
GitHub Actions / Qodana for C/C++ completed Sep 28, 2024 in 0s

18531 new problems found by Qodana for C/C++

Qodana for C/C++

1218 new problems were found

Inspection name Severity Problems
misra-cpp2008-5-0-11 🔶 Warning 909
magic-numbers 🔶 Warning 42
err33-c 🔶 Warning 38
implicit-bool-conversion 🔶 Warning 28
static-accessed-through-instance 🔶 Warning 17
misra-cpp2008-5-0-5 🔶 Warning 16
unroll-loops 🔶 Warning 14
unnecessary-value-param 🔶 Warning 12
misra-cpp2008-5-0-13 🔶 Warning 12
function-cognitive-complexity 🔶 Warning 12
qualified-auto 🔶 Warning 11
misra-cpp2008-5-0-6 🔶 Warning 11
narrowing-conversions 🔶 Warning 10
misra-cpp2008-5-3-1 🔶 Warning 10
easily-swappable-parameters 🔶 Warning 7
misra-cpp2008-5-2-12 🔶 Warning 6
simplify-boolean-expr 🔶 Warning 6
misra-cpp2008-4-5-2 🔶 Warning 5
for-range-copy 🔶 Warning 5
misra-cpp2008-0-1-7 🔶 Warning 4
convert-member-functions-to-static 🔶 Warning 4
use-starts-ends-with 🔶 Warning 3
id-dependent-backward-branch 🔶 Warning 3
redundant-string-init 🔶 Warning 3
misra-cpp2008-5-0-14 🔶 Warning 2
inconsistent-declaration-parameter-name 🔶 Warning 2
const-return-type 🔶 Warning 2
uppercase-literal-suffix 🔶 Warning 2
misra-cpp2008-6-4-2 🔶 Warning 2
redundant-casting 🔶 Warning 2
duplicate-include 🔶 Warning 2
misra-cpp2008-6-4-5 🔶 Warning 1
no-automatic-move 🔶 Warning 1
too-small-loop-variable 🔶 Warning 1
signed-bitwise 🔶 Warning 1
misra-cpp2008-2-13-3 🔶 Warning 1
unnecessary-copy-initialization 🔶 Warning 1
misra-cpp2008-2-13-4 🔶 Warning 1
misra-cpp2008-5-3-2 🔶 Warning 1
branch-clone 🔶 Warning 1
unused-parameters 🔶 Warning 1
misra-cpp2008-5-0-12 🔶 Warning 1
pro-type-member-init 🔶 Warning 1
readability-casting 🔶 Warning 1
make-member-function-const 🔶 Warning 1
else-after-return 🔶 Warning 1
pass-by-value 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2024.1.11
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 30 in src/account/account.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-11 

MISRA 5-0-11: The plain char type shall only be used for the storage and use of character values

Check warning on line 38 in src/account/account.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-11 

MISRA 5-0-11: The plain char type shall only be used for the storage and use of character values

Check warning on line 471 in src/creatures/creature.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

err33-c 

the value returned by this function should not be disregarded; neglecting it may lead to errors

Check warning on line 756 in src/creatures/creature.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

err33-c 

the value returned by this function should not be disregarded; neglecting it may lead to errors

Check warning on line 1810 in src/creatures/creature.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

err33-c 

the value returned by this function should not be disregarded; neglecting it may lead to errors

Check warning on line 1817 in src/creatures/creature.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-5 

MISRA 5-0-5: There shall be no implicit floating-integral conversions

Check warning on line 1821 in src/creatures/creature.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-5 

MISRA 5-0-5: There shall be no implicit floating-integral conversions

Check warning on line 518 in src/lua/functions/core/game/game_functions.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-11 

MISRA 5-0-11: The plain char type shall only be used for the storage and use of character values

Check warning on line 543 in src/lua/functions/core/game/game_functions.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-11 

MISRA 5-0-11: The plain char type shall only be used for the storage and use of character values

Check warning on line 52 in src/creatures/interactions/chat.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

err33-c 

the value returned by this function should not be disregarded; neglecting it may lead to errors

Check warning on line 447 in src/creatures/interactions/chat.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

err33-c 

the value returned by this function should not be disregarded; neglecting it may lead to errors

Check warning on line 451 in src/creatures/interactions/chat.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

err33-c 

the value returned by this function should not be disregarded; neglecting it may lead to errors

Check warning on line 455 in src/creatures/interactions/chat.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

err33-c 

the value returned by this function should not be disregarded; neglecting it may lead to errors

Check warning on line 461 in src/creatures/interactions/chat.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

err33-c 

the value returned by this function should not be disregarded; neglecting it may lead to errors

Check warning on line 462 in src/creatures/interactions/chat.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

err33-c 

the value returned by this function should not be disregarded; neglecting it may lead to errors

Check warning on line 774 in src/lua/functions/creatures/creature_functions.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

err33-c 

the value returned by this function should not be disregarded; neglecting it may lead to errors

Check warning on line 114 in src/creatures/monsters/monster.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-5 

MISRA 5-0-5: There shall be no implicit floating-integral conversions

Check warning on line 119 in src/creatures/monsters/monster.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-5 

MISRA 5-0-5: There shall be no implicit floating-integral conversions

Check warning on line 122 in src/creatures/monsters/monster.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-5 

MISRA 5-0-5: There shall be no implicit floating-integral conversions

Check warning on line 129 in src/creatures/monsters/monster.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-5 

MISRA 5-0-5: There shall be no implicit floating-integral conversions

Check warning on line 132 in src/creatures/monsters/monster.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-5 

MISRA 5-0-5: There shall be no implicit floating-integral conversions

Check warning on line 153 in src/creatures/monsters/monster.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

narrowing-conversions 

narrowing conversion from 'float' to 'int32_t' (aka 'int')

Check warning on line 153 in src/creatures/monsters/monster.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

narrowing-conversions 

narrowing conversion from 'int32_t' (aka 'int') to 'float'

Check warning on line 153 in src/creatures/monsters/monster.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-5 

MISRA 5-0-5: There shall be no implicit floating-integral conversions

Check warning on line 380 in src/creatures/monsters/monster.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

unnecessary-value-param 

parameter 'attackerPlayer' is passed by value and only copied once; consider moving it to avoid unnecessary copies
View more details on GitHub Actions