Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gamestore cpp #2834

Open
wants to merge 47 commits into
base: main
Choose a base branch
from
Open

feat: gamestore cpp #2834

wants to merge 47 commits into from

Conversation

murilo09
Copy link
Contributor

@murilo09 murilo09 commented Aug 20, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Behaviour

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Contributor

github-actions bot commented Aug 20, 2024

Qodana for C/C++

178 new problems were found

Inspection name Severity Problems
magic-numbers 🔶 Warning 44
implicit-bool-conversion 🔶 Warning 18
misra-cpp2008-5-0-6 🔶 Warning 14
misra-cpp2008-5-0-13 🔶 Warning 10
unroll-loops 🔶 Warning 10
qualified-auto 🔶 Warning 9
unnecessary-value-param 🔶 Warning 9
simplify-boolean-expr 🔶 Warning 6
misra-cpp2008-5-3-1 🔶 Warning 6
misra-cpp2008-2-13-3 🔶 Warning 5
init-variables 🔶 Warning 5
function-cognitive-complexity 🔶 Warning 5
narrowing-conversions 🔶 Warning 4
easily-swappable-parameters 🔶 Warning 4
for-range-copy 🔶 Warning 3
redundant-string-init 🔶 Warning 3
misra-cpp2008-5-0-12 🔶 Warning 3
convert-member-functions-to-static 🔶 Warning 3
misra-cpp2008-0-1-7 🔶 Warning 3
misra-cpp2008-5-0-5 🔶 Warning 2
const-return-type 🔶 Warning 2
misra-cpp2008-6-4-2 🔶 Warning 2
id-dependent-backward-branch 🔶 Warning 1
unused-parameters 🔶 Warning 1
branch-clone 🔶 Warning 1
pro-type-member-init 🔶 Warning 1
readability-casting 🔶 Warning 1
redundant-casting 🔶 Warning 1
make-member-function-const 🔶 Warning 1
else-after-return 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2024.1.9
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link
Contributor

@phacUFPE phacUFPE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a list of the missing contents.

  • Store only accepting transferable tibia coins as payment
  • Bundle
  • Hirelings
  • Name change
  • XP Boost
  • Check if Vip System activated
  • Integration with Cyclopedia info and history
  • Set transferable coins as default
  • Change string format to fmt

src/io/functions/iologindata_load_player.cpp Outdated Show resolved Hide resolved
src/creatures/players/player.cpp Show resolved Hide resolved
src/game/game.cpp Outdated Show resolved Hide resolved
src/game/game.cpp Outdated Show resolved Hide resolved
src/io/functions/iologindata_save_player.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@dudantas dudantas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave some suggestions, but I'll commit the corrections now.

src/account/account_repository.hpp Outdated Show resolved Hide resolved
src/account/account_repository_db.cpp Outdated Show resolved Hide resolved
src/account/account_repository_db.hpp Outdated Show resolved Hide resolved
src/creatures/players/player.cpp Outdated Show resolved Hide resolved
src/creatures/players/player.cpp Outdated Show resolved Hide resolved
src/creatures/players/player.cpp Outdated Show resolved Hide resolved
src/creatures/players/player.cpp Outdated Show resolved Hide resolved
src/creatures/players/player.hpp Outdated Show resolved Hide resolved
src/game/game.cpp Outdated Show resolved Hide resolved
src/game/game.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Sep 18, 2024

Qodana for C/C++

1218 new problems were found

Inspection name Severity Problems
misra-cpp2008-5-0-11 🔶 Warning 909
magic-numbers 🔶 Warning 42
err33-c 🔶 Warning 38
implicit-bool-conversion 🔶 Warning 28
static-accessed-through-instance 🔶 Warning 17
misra-cpp2008-5-0-5 🔶 Warning 16
unroll-loops 🔶 Warning 14
unnecessary-value-param 🔶 Warning 12
misra-cpp2008-5-0-13 🔶 Warning 12
function-cognitive-complexity 🔶 Warning 12
qualified-auto 🔶 Warning 11
misra-cpp2008-5-0-6 🔶 Warning 11
narrowing-conversions 🔶 Warning 10
misra-cpp2008-5-3-1 🔶 Warning 10
easily-swappable-parameters 🔶 Warning 7
misra-cpp2008-5-2-12 🔶 Warning 6
simplify-boolean-expr 🔶 Warning 6
misra-cpp2008-4-5-2 🔶 Warning 5
for-range-copy 🔶 Warning 5
misra-cpp2008-0-1-7 🔶 Warning 4
convert-member-functions-to-static 🔶 Warning 4
use-starts-ends-with 🔶 Warning 3
id-dependent-backward-branch 🔶 Warning 3
redundant-string-init 🔶 Warning 3
misra-cpp2008-5-0-14 🔶 Warning 2
inconsistent-declaration-parameter-name 🔶 Warning 2
const-return-type 🔶 Warning 2
uppercase-literal-suffix 🔶 Warning 2
misra-cpp2008-6-4-2 🔶 Warning 2
redundant-casting 🔶 Warning 2
duplicate-include 🔶 Warning 2
misra-cpp2008-6-4-5 🔶 Warning 1
no-automatic-move 🔶 Warning 1
too-small-loop-variable 🔶 Warning 1
signed-bitwise 🔶 Warning 1
misra-cpp2008-2-13-3 🔶 Warning 1
unnecessary-copy-initialization 🔶 Warning 1
misra-cpp2008-2-13-4 🔶 Warning 1
misra-cpp2008-5-3-2 🔶 Warning 1
branch-clone 🔶 Warning 1
unused-parameters 🔶 Warning 1
misra-cpp2008-5-0-12 🔶 Warning 1
pro-type-member-init 🔶 Warning 1
readability-casting 🔶 Warning 1
make-member-function-const 🔶 Warning 1
else-after-return 🔶 Warning 1
pass-by-value 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2024.1.11
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@dudantas dudantas marked this pull request as ready for review September 28, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants