-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme: Add section about how translations work #245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinging @bhousel @quincylvania for review; they appear to be the only folks who have permission to administer this translation pipeline end-to-end from this repository through NPM to Transifex.
- Change the order of the bullets to clarify which goes where. - Update the primary Transifex link based on feedback in openstreetmap#245 (comment) - Add a section about how to find a translation in Transifex
Looking into this with the Feedback of Minh in #245 (comment), there are two more thinks I think we should look at
|
Transifex has a button to ask to join the translation team for a given locale. In the past, the administrators of this Transifex project would approve requests routinely, only rejecting requests for overly specific locales.
Do you mean the review process for translations? Transifex does have a separate Reviewer role in order to mark translations as reviewed. This Transifex feature is generally only used for projects that rely on freelancers or contractors to provide initial translations. However, for Vietnamese, iD only pulls in reviewed translations: several years ago, someone used the Vietnamese locale as a dumping ground for their machine translation project, so this extra level of review prevented the machine translation from going live automatically.
Nothing in interim/source_strings.yaml currently uses this placeholder syntax. There is the |
Just seeing this is a duplicate of: #200. I think the additional info added here will be useful as well. When you find the time, please do make appropriate change. |
@1ec5 thanks for those answers. I updated the PR. I left out a some of the parts you answered since – now that I know – I think they are not too relevant to be explained to everyone. I added a bullet to answer the question "when will I see my translations in iD(…)". Another review would be great.
|
It's possible for the person doing the merge in GitHub to do the squash as part of the merge. Or alternatively you can do it as part of a PR in your branch to do it all on the website. |
Readme: Add section about how translations work Closes openstreetmap#55 Readme: Improve section about translations - Change the order of the bullets to clarify which goes where. - Update the primary Transifex link based on feedback in openstreetmap#245 (comment) - Add a section about how to find a translation in Transifex
Co-authored-by: Minh Nguyễn <mxn@1ec5.org>
Closes #55
I had to search around for this – again – just now for bryceco/GoMap#562. I think this should be clarified right in the Readme.