Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: How does translation work #55

Closed
tordans opened this issue Nov 15, 2020 · 4 comments · Fixed by #245
Closed

Documentation: How does translation work #55

tordans opened this issue Nov 15, 2020 · 4 comments · Fixed by #245

Comments

@tordans
Copy link
Collaborator

tordans commented Nov 15, 2020

I was looking at https://github.com/openstreetmap/id-tagging-schema to find the link about where to translate things. Its probably at https://www.transifex.com/openstreetmap/id-editor/translate/#de/presets/30538703?q=text%3A'Hearing+Aids+Store'. A section with the link and about how it works in the readme would be great, IMO.

@tordans
Copy link
Collaborator Author

tordans commented Nov 16, 2020

Another detail for the documentation:

Should terms for english be put in Transifex as part of the .terms translation (eg https://www.transifex.com/openstreetmap/id-editor/translate/#en_GB/presets/30538703?q=text%3A'Aids+Store') or should they be put in the JSON like

"terms": [
"bush",
"scrub"
],
?

@quincylvania
Copy link
Collaborator

@tordans Yep, the translations continue to live at the id-editor Transifex project for now. I'll update the readme.

Should terms for english be put in Transifex as part of the .terms translation (eg https://www.transifex.com/openstreetmap/id-editor/translate/#en_GB/presets/30538703?q=text%3A'Aids+Store') or should they be put in the JSON like

The US English terms go in the JSON data. If we need different terms for a different English locale, those can be translated on Transifex. But it's usually better to put local terms from the UK or other speaking countries directly in the US terms.

tordans added a commit to tordans/id-tagging-schema that referenced this issue Oct 5, 2021
@peternewman
Copy link
Contributor

Is #200 having been merged sufficient to close this, or do people want all the detail of #245 to go in first?

I wonder if a lot of the detail from #245 is sufficiently generic enough it could just live at the destination of the link (i.e. in the main iD repo)?

@tordans
Copy link
Collaborator Author

tordans commented Nov 11, 2021

@peternewman I have been working on clarifying the process to new users in #245 for a while now and would very much like to see it merged. The questions in the PR are thinks that I wonder myself and that one cannot find the answer to unless asking. I do not see any reason not to finish the PR.

Update:
And no, #200 does only explain half the story since – like this issue figured out – some translations need to be put in the JSON, others in Transifex. That at least should be explained.

tordans added a commit to tordans/id-tagging-schema that referenced this issue Nov 11, 2021
Readme: Add section about how translations work

Closes openstreetmap#55

Readme: Improve section about translations

- Change the order of the bullets to clarify which goes where.
- Update the primary Transifex link based on feedback in openstreetmap#245 (comment)
- Add a section about how to find a translation in Transifex
tyrasd added a commit that referenced this issue Dec 13, 2021
* Readme: Expand translations section

Readme: Add section about how translations work

Closes #55

Readme: Improve section about translations

- Change the order of the bullets to clarify which goes where.
- Update the primary Transifex link based on feedback in #245 (comment)
- Add a section about how to find a translation in Transifex

* fix typo and bind to specific version

Co-authored-by: Minh Nguyễn <mxn@1ec5.org>

* tweak wording very slightly

Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Minh Nguyễn <mxn@1ec5.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants