-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Extended guidelines for presets, fields, deprecations #1229
Conversation
This is heavily inspired by https://github.com/streetcomplete/StreetComplete/blob/master/QUEST_GUIDELINES.md – thanks a lot
🍱 You can preview the tagging presets of this pull request here. |
I suggest enhancing the guidelines by recommending that new presets inherit fields from more commonly used presets. For example, when creating a specific shop type, inherit fields from the general shop preset and then add specific fields as needed. This ensures consistency, reduces redundancy, and simplifies maintenance. When the general preset is updated, the specific presets automatically inherit these updates, keeping everything current and consistent. Additionally, it might be helpful to include best practices for testing new presets to ensure they function correctly within the tagging schema. Other than that is all seems good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great summary of the current maintenance practices of this data set. Thanks a lot @tordans!
This is currently documented on the
👍 this would definitely be useful to be included. But let's still merge the doc as it is for now and improve upon it in follow up PRs. 🤓 |
@tyrasd following our conversation on the last iD community call I created this draft of a separate document that outlines the decisions that guide adding presets, fields and so on.
I suggest we collect some feedback but the start using it which will be the best way to improve it over time.
This is heavily inspired by https://github.com/streetcomplete/StreetComplete/blob/master/QUEST_GUIDELINES.md – thanks a lot