Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape arguments by default #10

Merged
merged 4 commits into from
May 20, 2020
Merged

Escape arguments by default #10

merged 4 commits into from
May 20, 2020

Conversation

jonhoo
Copy link
Collaborator

@jonhoo jonhoo commented May 20, 2020 •
edited
Loading

Since that matches std::process::Command more closely.
Breaks with weird remote shells, but raw_ provides an escape hatch.

sfackler/shell-escape#5 is a little sad.

@codecov
Copy link

codecov bot commented May 20, 2020 •
edited
Loading

Codecov Report

Merging #10 into master will increase coverage by 0.51%.
The diff coverage is 77.77%.

Impacted Files Coverage Δ
src/sftp.rs 74.11% <64.28%> (+0.78%) ⬆️
src/command.rs 89.39% <88.88%> (+1.67%) ⬆️
src/lib.rs 79.01% <100.00%> (+0.53%) ⬆️

akshayknarayan
akshayknarayan approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@akshayknarayan akshayknarayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, documentation explanations make sense to me.

src/command.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/command.rs Outdated Show resolved Hide resolved
@jonhoo jonhoo merged commit 1cb05f3 into master May 20, 2020
@jonhoo jonhoo deleted the escape-by-default branch May 20, 2020 13:19
@jonhoo
Copy link
Collaborator Author

jonhoo commented May 20, 2020 •
edited
Loading

Released in 0.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayknarayan akshayknarayan akshayknarayan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonhoo @akshayknarayan