Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for OsString #5

Open
pronebird opened this issue Apr 5, 2018 · 1 comment
Open

Support for OsString #5

pronebird opened this issue Apr 5, 2018 · 1 comment

Comments

@pronebird
Copy link

pronebird commented Apr 5, 2018 •
edited
Loading

Hi,

Great piece of work. However I face issues using it on Windows. It forces me to go through UTF-8 String, but Windows uses UTF-16 UCS2 strings. So it's incompatible in a way with the platform.
@jonhoo
Copy link

jonhoo commented May 20, 2020

I would also be interested in this, not for Windows support, but just so that it's possible to escape, say, a Path.

@jonhoo jonhoo mentioned this issue May 20, 2020
Merged
jonhoo added a commit to openssh-rust/openssh that referenced this issue May 20, 2020
@jonhoo
Escape arguments by default (#10)
1cb05f3 
Since that matches `std::process::Command` more closely.
Breaks with weird remote shells, but `raw_` provides an escape hatch.

sfackler/shell-escape#5 is a little sad.
@aalekhpatel07 aalekhpatel07 mentioned this issue Feb 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonhoo @pronebird