Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exponential Brightness #539

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

rogere66
Copy link
Contributor

@rogere66 rogere66 commented Dec 13, 2022

Make brightness exponential. Exponential mode can be set with command led_expoMode <0..4>:
0 = Off
1 = 1% min brightness with moderate exponential
2 = 1% min brightness with full exponential (default)
3 = 0.1% min brightness with moderate exponential
4 = 0.1% min brightness with full exponential
The mode can be set at startup by the "Change startup command text" Config command.
Modes 3 & 4 will not be very useful yet since minimum brightness is currently limited to 1%.

@openshwprojects
Copy link
Owner

It seems that you need to fix compilation for BL602 platform by adding a header for pow

@rogere66
Copy link
Contributor Author

Ok. Added <math.h> and also changed pow to powf, the proper float version. The BL602 platform then apparently use stricter checks than BK7231 - maybe an idea to use stricter checks on every platform - even stricter than now.

@openshwprojects
Copy link
Owner

There is still some issue but I will fix it for you after meging.

@openshwprojects openshwprojects merged commit 45697d3 into openshwprojects:main Dec 14, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.15.181 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rogere66 rogere66 deleted the Exponential_Brightness branch January 9, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants