Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Led brightness/expo mode default value? #541

Closed
openshwprojects opened this issue Dec 14, 2022 · 3 comments
Closed

Led brightness/expo mode default value? #541

openshwprojects opened this issue Dec 14, 2022 · 3 comments

Comments

@openshwprojects
Copy link
Owner

After merging in #539 ,
/* exponential mode command handler, usage: led_expoMode <0|1|2|3|4>
exponential modes: 0 = Off
1 = 1% min brightness with moderate exponential
2 = 1% min brightness with full exponential
3 = 0.1% min brightness with moderate exponential
4 = 0.1% min brightness with full exponential
*/

I think we should choose a default value for brightness mode on all devices.

Can you guys check which one in your opinion gives best results?
Currently, the default value is 0 = Off

@WiredLife
Copy link

#546

@WiredLife
Copy link

I updated to current firmware and the expo mode doesnt work as i thought, tried all settings. With #447 i can go very down with the brightness.
With the expo mode not.
Very sad

@openshwprojects
Copy link
Owner Author

@WiredLife You have convinced me. We're merging #447 soon. I will allow float values for PWMs. I am closing this issue now, let's continue discussion in #447 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants