Timestamps on charts showing wrong time #1376
Comments
ehorvat1
added a commit
to ehorvat1/OpenBK7231T_App_incl_Charts
that referenced
this issue
Oct 3, 2024
Fix issue openshwprojects#1376 .....wrong time in charts when using NTP with an offset
openshwprojects
pushed a commit
that referenced
this issue
Oct 3, 2024
* Fix issue #1376 Fix issue #1376 .....wrong time in charts when using NTP with an offset * Update drv_charts.c Issue #1375 For issue #1375: add a default color to improve readability (applies to: dataset names, axis ticks, color for axes title, (use color: '#99') * Update drv_charts.c Add a chart title * Update obk_config.h Set ENABLE_DRIVER_CHARTS = 1 also for Beken Devices * Update http_fns.c Add charts to About page * Update obk_config.h File just cloned from openshwprojects/OpenBK7231T_App * Revert "Update obk_config.h" This reverts commit b83c7db. * Revert "Update obk_config.h" This reverts commit 7b7d979. * Revert "Update http_fns.c" This reverts commit d81e4b3. * Revert "Update drv_charts.c" This reverts commit c5d1229.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Charts are a great feature, thanks again.
Timestamps on x axis show incorrect time if NTP driver is used with an offset.
Since NTP driver delivers already correct unix timestamp values the drv_charts.c file could be changed.
Exchanging:
Chart_AddTime(g_chart, NTP_GetCurrentTime());
with:
Chart_AddTime(g_chart, NTP_GetCurrentTimeWithoutOffset());
in line 628 of drv_charts.c would be my proposed fix.
I will send a pull request for this .
Rg, Bert
The text was updated successfully, but these errors were encountered: